The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [GIT pull] timers/core for v7.2-rc1
Date: Tue, 16 Jun 2026 16:18:43 +0200	[thread overview]
Message-ID: <875x3i36ws.ffs@fw13> (raw)
In-Reply-To: <ai__mdoKsWR5lIlY@redhat.com>

On Mon, Jun 15 2026 at 15:35, Oleg Nesterov wrote:
>>  struct clocksource * __init __weak clocksource_default_clock(void)
>>  {
>> +	if (!cs_jiffies_registered) {
>> +		__clocksource_register(&clocksource_jiffies);
>> +		cs_jiffies_registered = true;
>> +	}
>>  	return &clocksource_jiffies;
>>  }
>
> It seems that this change is problematic...
>
> timekeeping_init() does
>
> 	guard(raw_spinlock_irqsave)(&tk_core.lock);
>
> 	clock = clocksource_default_clock();
>
> and __clocksource_register() -> __clocksource_register_scale() takes
> clocksource_mutex.

Dammit. I missed to enable lockdep. The sleep while atomic muck does not
catch it because it's early boot. Someone sent a patch already. I'll get
the fix to Linus ASAP.

Thanks,

        tglx

  reply	other threads:[~2026-06-16 14:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 21:24 [GIT pull] core/rseq for v7.2-rc1 Thomas Gleixner
2026-06-13 21:24 ` [GIT pull] irq/core " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:24 ` [GIT pull] irq/drivers " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:24 ` [GIT pull] irq/msi " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:25 ` [GIT pull] smp/core " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:25 ` [GIT pull] timers/clocksource " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:25 ` [GIT pull] timers/core " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-15 13:35   ` Oleg Nesterov
2026-06-16 14:18     ` Thomas Gleixner [this message]
2026-06-13 21:25 ` [GIT pull] timers/nohz " Thomas Gleixner
2026-06-15  8:00   ` Ingo Molnar
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:25 ` [GIT pull] timers/ptp " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-13 21:25 ` [GIT pull] timers/vdso " Thomas Gleixner
2026-06-15  8:51   ` pr-tracker-bot
2026-06-15  8:51 ` [GIT pull] core/rseq " pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x3i36ws.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox