From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8CE35AC20 for ; Tue, 2 Jun 2026 09:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394266; cv=none; b=lhSeTvaYWWmoa0y+pRQvweVeTaKj9H/AqHU0wuBkn2iOPAyTA5+2MBHc5lNnoZl+drAaGBCe7C2N/Q38pz+LFk991+UWmCO/zRa3wRVUt0AQbkNXm5CZHhbsWllKmVjjPoTPG5475TdOZdke1vl3gf+Ex0J81E2p2MKW68h3nHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394266; c=relaxed/simple; bh=0u63V9+LYPFlRcYSQLGK+a05/d0t31hfR6bXzap0stE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=eHmJtmvOJSYtE32Jyguk0enWc4laSIPfVBJkFZLEuFULDKNtS9SmW4TYQCAKsQcG3UGNETHdjgtOy1GXTbeCGVxx8BOl4047EEM1aQjm9BCC2SuC04WBm4JINiy8mjT1thmMDC/wcLS3cK1BEQKDKZDaKOhxg6T0OWZVMdba5XA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=sFXLZwLG; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="sFXLZwLG" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 107A04E42DC0; Tue, 2 Jun 2026 09:57:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CAB59603BC; Tue, 2 Jun 2026 09:57:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D5E3B1088817C; Tue, 2 Jun 2026 11:57:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780394254; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=6YEAwXu9u2T6foeNhTKGbgxkWXhM35Rvs16f6vC//7A=; b=sFXLZwLGRi4NTRx1H+ElbZWS4oiapNv3Pe5YJM321FdCengPRmf2Ri8UepUHA2b64q9kFa E8zJzwPJRVe8l1iJ2cSbeuWI7UjgpI2AKLAdl57ozwwslZyQgZqdn+NUTZDmPSU7fotTSH V4jHGMgwNMM1zALotrh6/sVuPwALB4JldESgTCHj2RXekBca2ngZZd3hOKwLnFXRo+SFcR MlblrG18XVD/oQvTY3yMtdaCnKOnrfCQlRB1mLCYZqAn/7Pmw2NzpFm8ccRKHgmA3dbB64 bep7rV2wsFIP7iX4TCXBxbAIoh/4Cj+Og2FsHXH76zmv+zP6FIe1AnKazZuK1w== From: Miquel Raynal To: Michael Walle Cc: Pratyush Yadav , Takahiro Kuwano , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag In-Reply-To: <20260601125438.3481722-2-mwalle@kernel.org> (Michael Walle's message of "Mon, 1 Jun 2026 14:52:43 +0200") References: <20260601125438.3481722-1-mwalle@kernel.org> <20260601125438.3481722-2-mwalle@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 02 Jun 2026 11:57:31 +0200 Message-ID: <875x41nu2c.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 Hi Michael, > diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c > index 65227d989de1..092450375d4e 100644 > --- a/drivers/mtd/spi-nor/spansion.c > +++ b/drivers/mtd/spi-nor/spansion.c > @@ -868,7 +868,7 @@ static const struct flash_info spansion_nor_parts[] = { > .name = "s25fl256s0", > .size = SZ_32M, > .sector_size = SZ_256K, > - .no_sfdp_flags = SPI_NOR_SKIP_SFDP | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > + .no_sfdp_flags = SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > .mfr_flags = USE_CLSR, > }, { > .id = SNOR_ID(0x01, 0x02, 0x19, 0x4d, 0x00, 0x81), Fine by me. I believe the expected behaviour should just be an empty feedback, leading to the SFDP to be invalid and thus SFDP parsing skipped, right?