From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FB1B381B1A for ; Mon, 25 May 2026 12:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779711982; cv=none; b=lkpGQJOtHXLuTTftyMgbvluacj8icqaOWL/5yJaavY3KMBECZ1oUBJiS5OdV1v6SLcoJ+a1APp0slUc9TJDcGWRYZUbfYuGbb4ee4WV+e+lpYdT+9WxWyQiYduhjvSo/1mRb7W1biSX0Nyj+4Ptkp9ikbAbC4v6eerNsUS9aEck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779711982; c=relaxed/simple; bh=XKd3/sBVdFq7scHu0YsvYg3lOUwCrl49yVJU6hxqojc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=siauqNbDgh/vmoL8Gqd7BC2eoq62+tz8qbH6fAoQAc+c4hXmbTWMJNRDQFFmYWTFMy/wQcmwH4F+idV6fP6B+gyoDDdIg8hYS4zKZF3FJMyWrjGBJ9i/JpjkxQGFGFYl0xDXs0RnzelWZ74TmpOVhHLbjj27OQdB+UAltgmbHWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T/lOEKCe; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=V3Zb20dV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T/lOEKCe"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="V3Zb20dV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779711980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4hkd86DeSZBRxqkEKxXYxQ6Fg5bw2Xdd0Nw7s4mAqxY=; b=T/lOEKCeN8ZgBnQe8l+GICI16pqW+1ms7o1ohH2E2atpQ3Y1jZr+TlifjxqtH4vXoE2gdB dGBeXM9GX1638hjS/GKkuv2rOCbzFu+enuHLTa+u1FNqvK61BrTH9q+yXj4uC8ZTg6x4b1 J8M0k6DfGDfssfLhZ8N1wotIbk7Wazc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138--uB12lWeN6qcuLqnYgqA5g-1; Mon, 25 May 2026 08:26:19 -0400 X-MC-Unique: -uB12lWeN6qcuLqnYgqA5g-1 X-Mimecast-MFC-AGG-ID: -uB12lWeN6qcuLqnYgqA5g_1779711978 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48fd3dbd16aso76668955e9.0 for ; Mon, 25 May 2026 05:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779711978; x=1780316778; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4hkd86DeSZBRxqkEKxXYxQ6Fg5bw2Xdd0Nw7s4mAqxY=; b=V3Zb20dVjHJQvBWw+ViTWlfBtxLVs3bMm4kfJIfFn9XNdNGTATFAh39d8A80NXn5dR DNETLpj7ygVeu/wGcu62/rrEP2ui9LQ+LsqnF5i/2944Q6Uv5P9K0uj9zmFoVH9NL90m 9HORkLlFhjgtI0xk3DyMrCrxqNHZYICj2IRS7x8KJfwoN56uvy+9x65WRF79LTZ3fMfe PSztA/nd1BfF/nUP/0q2qxe2RAelscpyo3R6CgzbLtW9qKTjv2qDx4Aloi5Y/Ne13TNZ pKIuZ//AOi9NXdPFygtRPnKahv5G0WfD3MWymHcXKDNzLLqD+8PVWZ3+bVw32++BPcYJ 6HwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779711978; x=1780316778; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4hkd86DeSZBRxqkEKxXYxQ6Fg5bw2Xdd0Nw7s4mAqxY=; b=ctzlXsbpfDJuZdhQLB5b+5baE/JwgwJWXuC5Ih/28FTl4YxO6GjZPDmTvaP69x81Pp mNPzJsasMQYYX9TFuFjYo0vMkCsF8IDGr7XXKr38pB1pWfso3bISUUcHaigTjOQFdJSv OoeXDez8KbXDoFPWwaaiYoY0J0k45yzF87dKyCfCyNakZBLVkkUJOkq4H2wdT2XFTN0o 0Tys2D0fXNZ1HfeSdNXm38WaIcP5Q585G73h9WWTxph+HGzGc6HnH4qxXvha9eLjLJ0Y I0eLoYiCgb1Gpf8iE0EPg/xKQY03IDGgxJF708uZUssoRvAwIVlPx4XvGxVpxkRODpRX 1QEA== X-Forwarded-Encrypted: i=1; AFNElJ9+iURVXB4UVQbAt9ndt8N9Vxwr/U7LOkeLlyNIefhWBlNUv/DHZJSmzsh6I2j6qCB3jIrdP4eJwcobfpg=@vger.kernel.org X-Gm-Message-State: AOJu0YyD6ZNPsGbfwnQGZw18UyZN95Wiex5xWWCph/qEzwPGJSHq8NIt x87FNvEaf5v+neUvDcv3xslgNyvZo2hIYadGvPhd6r6k/5w3x5O78taGpli/tDT3qwRofiCaFyi Up6TuY3W7iVb8K81qjMveqKzALbUWVQ1CtGfGoenMOS2E0gg3n0jdQXajIUBIGVfn7fdfYNjUe8 RZVGyaX/zlZgihUfG4HFiKPhmYu68BQYgnoTssZuA19R+PHc5yLQ== X-Gm-Gg: Acq92OGeuq+nIiZAl+hC4ZzFeq6s5vr1svZVEagbXTa4EUVTVbSjF1msBYnBTOk6ww6 Hjc2+nlAM/CJbT5yogn5CDQsW2HHYZJA0Y1VroRBJ5R3Et2rahUKwWbRjtd5liEufEt7ZCN4bxu VkCKDlwoTMxx1GbifUAxj5DkIGIJaSv2gEIYT7yvEYls3E+r4G6MLiOZWjmRO5lvqE5sApFa1Fb JkR9IyCoHzC9HUxchXpfhlP+CBLnRFvCZNIiHyUyi3IoRCEAZG3GkiyXmeN2JBU3SClh4E/cvx1 qVkCrqUrgOUPpglemEJIuKgUhd3gxvqZm11BJnTyTVVpJteuyi3bqNt13kF4aOIQh0lsRFbeb+N zNvojhe7Ny/48Xa8uR+qwKCg= X-Received: by 2002:a05:600c:34c5:b0:490:601f:d775 with SMTP id 5b1f17b1804b1-490601fd89emr86929685e9.5.1779711977987; Mon, 25 May 2026 05:26:17 -0700 (PDT) X-Received: by 2002:a05:600c:34c5:b0:490:601f:d775 with SMTP id 5b1f17b1804b1-490601fd89emr86929055e9.5.1779711977417; Mon, 25 May 2026 05:26:17 -0700 (PDT) Received: from fedora (nat-20.ign.cz. [91.219.240.20]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49045282201sm272209365e9.8.2026.05.25.05.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 05:26:16 -0700 (PDT) From: Vitaly Kuznetsov To: Piotr Zarycki , seanjc@google.com, pbonzini@redhat.com Cc: shuah@kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: hyperv_features: test write of 1 to HV_X64_MSR_RESET In-Reply-To: References: <20260523111857.195396-1-piotr.zarycki@gmail.com> Date: Mon, 25 May 2026 14:26:15 +0200 Message-ID: <875x4bllp4.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Piotr Zarycki writes: > Hi, > > After receiving KVM_SYSTEM_EVENT_RESET the test simply advances to the > next stage without resetting the vCPU. Is verifying > KVM_SYSTEM_EVENT_RESET is delivered sufficient? > For every stage of this test we're basically using a new VM (vm_create_with_one_vcpu()) thus it does not really matter much what we do after receiving KVM_SYSTEM_EVENT_RESET. The basic idea behind the test was to verify that KVM_CAP_HYPERV_ENFORCE_CPUID works as expected, i.e. the guest gets access to the MSRs/hypercalls according to the guest visible CPUIDs and not to everything KVM knows about (I guess we could've named it 'hyperv_feature_access' to actually reflect that). It, however, makes sense to actually test side-effects of writing to MSRs/using hypercalls, especially when it's relatively easy and I see that the change here goes in this direction. With this, I think it is a good and sufficient change, so Reviewed-by: Vitaly Kuznetsov Thanks! -- Vitaly