From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520C13C5855
	for <linux-kernel@vger.kernel.org>; Thu, 21 May 2026 11:45:26 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779363929; cv=none; b=WWbl8WW3P7L+3AZBN5whXT0ucz1Xjt7iHxa/IixQP5Mb8584/z0T/w2qQO/qtxMKkE0XoKIgaKPTDdhPphx18tQXR/gb4fGlaPIifGXmK8iM6XhcDohGz3SPK6XnBs86hBUnJFI7y1LTQ7AjAd2AOxn2Xz/kNf3+WXJQtZ+t9pQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779363929; c=relaxed/simple;
	bh=8LOiX7ivVCVS5rOQKmL/OI8gfzgGW3QtG/4/M7gO4ok=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=EoRwaywZPzfk/J9Mvm2mGDlFfYRfkS9yfBsxicMG1nWR4yAJaaL/prGzjcLiwJ5ItEsaVzsJcsXMFhc9J4ZhwPCM+zLuSIhqtDywgXO0yE54ubPV2IiARehMCWwT103WwdUWL4uwyLA4QrVAdQNHeE0R/zl4nXDc3mtwryxjcwc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ctp0+TmV; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ctp0+TmV"
Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id AAF971F000E9;
	Thu, 21 May 2026 11:45:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779363926;
	bh=msT2XoX2mDBwKh/3GrjxQm5Wft6O64ISwsfuZ01n9XA=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=ctp0+TmV3ALkWJCJ+H/jSA+uqorY+jPb0MVOz7V1NcMNiR/srECJrqkF2oPYZjTdm
	 nOLV7CrqCNo1poRVfZIF8XW+x7IOqSCT2ucqQ2tgFtSxHBU85mUVmxnUZslR+ZMApZ
	 zMdebaM0lG4hjykb/0MFvSsgFyMPEH1+CgDmLHiDGXVp3VcLxVCu/MKX0vusxs1wK0
	 KkCq9UcLXZRSt9Psv/Gxa38NWeQDr8tVugIvEttafyeFwH/t6aW/DbWpx4jNzz4wrM
	 Qv08Rq3z0dbG8NJZIJxR95ddXmm98195LYSsD73wdaI4+qAEng2rpMepH0PLUzzgvO
	 Isc4eI73S0U5w==
From: Thomas Gleixner <tglx@kernel.org>
To: David Laight <david.laight.linux@gmail.com>, Thorsten Blum
 <thorsten.blum@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, David Hildenbrand
 <david@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>, "Liam R. Howlett"
 <liam@infradead.org>, Vlastimil Babka <vbabka@kernel.org>, Mike Rapoport
 <rppt@kernel.org>, Suren Baghdasaryan <surenb@google.com>, Michal Hocko
 <mhocko@suse.com>, Andy Lutomirski <luto@kernel.org>, Vincenzo Frascino
 <vincenzo.frascino@arm.com>, Kees Cook <kees@kernel.org>, Andy Shevchenko
 <andy@kernel.org>, Yury Norov <yury.norov@gmail.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to
 vdso/page.h
In-Reply-To: <20260521103029.561d5c02@pumpkin>
References: <20260521090655.160282-4-thorsten.blum@linux.dev>
 <20260521090655.160282-5-thorsten.blum@linux.dev>
 <20260521103029.561d5c02@pumpkin>
Date: Thu, 21 May 2026 13:45:22 +0200
Message-ID: <875x4hvve5.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Thu, May 21 2026 at 10:30, David Laight wrote:
> On Thu, 21 May 2026 11:06:57 +0200
> Thorsten Blum <thorsten.blum@linux.dev> wrote:
>> +#include <vdso/page.h>
>
> That is already picked up otherwise PAGE_MASK would be undefined.
>
> The whole vdso headers is a mess.
> I moved one of the definitions (to do with bitmasks) back into its main header.
> The vdso compiled fine because all the 'normal' kernel headers get included
> in vdso builds.

Which is just wrong and we had subtle issues due to that in the
past.

VDSO is a pure user space library and just because it compiles does not
mean it is correct.

Thanks,

        tglx