From: Thomas Gleixner <tglx@kernel.org>
To: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Nick Hu <nick.hu@sifive.com>, Anup Patel <anup@brainfault.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
Subject: Re: [PATCH] irqchip/riscv-aplic: fix PM for multi-aplic system
Date: Wed, 11 Mar 2026 19:21:28 +0100 [thread overview]
Message-ID: <875x72qlav.ffs@tglx> (raw)
In-Reply-To: <20260311143749.4058818-1-vladimir.kondratiev@mobileye.com>
On Wed, Mar 11 2026 at 16:37, Vladimir Kondratiev wrote:
> This results in double registration of the same syscore. Warning
> triggered:
>
> [ 0.553569] ------------[ cut here ]------------
> [ 0.553572] list_add double add: new=ffffffff81314a68, prev=ffffffff81314a68, next=ffffffff8131f588.
>
> Move syscore registration to the driver init
This is completely wrong because it installs the syscore ops
unconditionally even when there is no APLIC available in the
system. Works for me is not the right approach.
> Fixes: 95a8ddde3660 ("irqchip/riscv-aplic: Preserve APLIC states across suspend/resume")
No. It makes it worse.
> Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
But nothing to do here anymore. This got already fixed correctly:
https://lore.kernel.org/all/20260310141349432DBRJJclgnBHYWu8it0geX@zte.com.cn/
Thanks
tglx
next prev parent reply other threads:[~2026-03-11 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 14:37 [PATCH] irqchip/riscv-aplic: fix PM for multi-aplic system Vladimir Kondratiev
2026-03-11 18:21 ` Thomas Gleixner [this message]
2026-03-12 12:07 ` Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x72qlav.ffs@tglx \
--to=tglx@kernel.org \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nick.hu@sifive.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox