From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B02979CD for ; Wed, 11 Mar 2026 18:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253292; cv=none; b=mI/3B9cep0lxISp+D6gIly33bO+0TWavC6HeJz8rKG/6zjOoOqvG/WLvMj/t3rBmQvouPLFEhXPJjGuqkBfHFuY2KWBmtNT89uPT9YJWlC6ajTm7svDtg/aZPGgKj5OF6RLxltoNjCwJgciYHCWJeAYHUmabi0GSKqE1YSapl9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253292; c=relaxed/simple; bh=AJB4cnK+6nPF7XzrEc9Y40aawrnv3LRCOW/DGQO3ZZ8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=erjYVfwW2kP2oPBhcn+RwH4NH+Z+ELwynNckFhMd6apY6DfghWVnqkXCePUGPp1qRX6rHOmL1i8F6jwM1w5cJYQY21ku/tQv7RP2cKcq4N4agYdX/G+Qq79e3ZakPJ/PVk7AHgsWW2cDBuTWgyi0gm8yZQ7o+k9kr41qZ79zwhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W9tvad2a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W9tvad2a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2498CC4CEF7; Wed, 11 Mar 2026 18:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773253291; bh=AJB4cnK+6nPF7XzrEc9Y40aawrnv3LRCOW/DGQO3ZZ8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W9tvad2afirxz5QyDgrlCDCxXjihPnftjOpJ7+KqNngldAnfoQFK2cv9M//Hf6Csr ZSJHebet8RVatcWVMDWmhLOEwO74GZZPxCIMPAGzK+qjptr/YrTXxIADgkQdkZD9+F VYic28ogFaHKpZnfJAOvq93A0zlvilwkyAZ1qcskIj3XUbklvKcSgoTVAIDfC2ArWD gASlAXyrPtEd6zn//x4iMxb4Jb8/L5a/TYXmF3fSHYhifYueUYq+5w1piWPHN6xkRs YFK3M6wSAAtrItwdCJGNamJYdZfxIRJ01ybMlznZkJn70XpnbxO96d2d/U+R55o5Bu iMkpgT7xmlB9w== From: Thomas Gleixner To: Vladimir Kondratiev , Nick Hu , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev Subject: Re: [PATCH] irqchip/riscv-aplic: fix PM for multi-aplic system In-Reply-To: <20260311143749.4058818-1-vladimir.kondratiev@mobileye.com> References: <20260311143749.4058818-1-vladimir.kondratiev@mobileye.com> Date: Wed, 11 Mar 2026 19:21:28 +0100 Message-ID: <875x72qlav.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Mar 11 2026 at 16:37, Vladimir Kondratiev wrote: > This results in double registration of the same syscore. Warning > triggered: > > [ 0.553569] ------------[ cut here ]------------ > [ 0.553572] list_add double add: new=ffffffff81314a68, prev=ffffffff81314a68, next=ffffffff8131f588. > > Move syscore registration to the driver init This is completely wrong because it installs the syscore ops unconditionally even when there is no APLIC available in the system. Works for me is not the right approach. > Fixes: 95a8ddde3660 ("irqchip/riscv-aplic: Preserve APLIC states across suspend/resume") No. It makes it worse. > Signed-off-by: Vladimir Kondratiev But nothing to do here anymore. This got already fixed correctly: https://lore.kernel.org/all/20260310141349432DBRJJclgnBHYWu8it0geX@zte.com.cn/ Thanks tglx