From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313A1349B0A for ; Fri, 20 Feb 2026 13:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771595282; cv=none; b=uuVx/vomogOeV1TGd0WYphLCuBH9ruHpd8as/rhYMICkoLtOtfrBx4yJujGnwT1HUEvo86mt7gsfWyzto1R47lX/KUkpeUune7R/VkeLeLM9m4HN2FXu2bofRjeP5opTKsZfSjzutpEfs7wSkcEQstjwXqLNnGXzyLzuvDOMD4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771595282; c=relaxed/simple; bh=LCP4S7nW1w6rXQ4VX/NQCO9pkK1t1/d43vAMdFSN+pM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ISjQ7Dz+ujozjZTdk50AcO4oa/QcletnOadxByjh9o5hcFkHuZflNaMKBWl0+kiZD57PIHQc7H/8spPczBfHlJtDHmOJGNEH1+QuchiysVmsLoxe8qzHJCCyKfP1TSBgfCi/5M88En6ABMuO3RQPr2M2rJ0DxaHhRr5nxLbu7Fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=gYGSVqCz; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="gYGSVqCz" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 30DF2C19D14 for ; Fri, 20 Feb 2026 13:48:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5AEB75FA8F; Fri, 20 Feb 2026 13:47:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A9CF810368C65; Fri, 20 Feb 2026 14:47:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1771595278; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=LCP4S7nW1w6rXQ4VX/NQCO9pkK1t1/d43vAMdFSN+pM=; b=gYGSVqCzaJvVEVp+sFsTycrhl0mJ8c2PcZZl4bwwhJCsEVmK9CCMEIcQtlkeuaAmMqJ74j N4k+s6/ucf3JrJ5oIuy1QjzX9xjKGRmtJng5sRgtiaHKae8t+kum5WU0hzEnYOcz+8af25 rDN/obkkLjkz0PU6ZG3O8y0UuWEdIfB8w7o7nRmoBh8AOb6g11RnN7ni+7N0IhmqRW/zMb HnL71OKtAf1ja5YFWpa8yXbdI2mbu9JUHwaZb6oJ8fnW0X/570n8/HWbaNwSOM+NvRBo5R 7RNjUaXb3Htyht1NNPW+zoXLKhT+JwkMHJ5Zz0OkdF+C0z1bRx/606OmTTRnVw== From: Miquel Raynal To: Gabor Juhos Cc: Alan Stern , Greg Kroah-Hartman , Gregory CLEMENT , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] usb: ehci-orion: remove optional PHY handling code remnants In-Reply-To: <20260220-ehci-orion-drop-phy-handling-v1-1-01abd9f168cc@gmail.com> (Gabor Juhos's message of "Fri, 20 Feb 2026 14:27:02 +0100") References: <20260220-ehci-orion-drop-phy-handling-v1-1-01abd9f168cc@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 20 Feb 2026 14:47:56 +0100 Message-ID: <875x7rsf03.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Gabor, On 20/02/2026 at 14:27:02 +01, Gabor Juhos wrote: > Since the USB core code handles the generic USB PHYs automatically, the > optional PHY handling code has been removed from the 'ehci-orion' driver > entirely by commit e04585184dcf ("usb: ehci-orion: avoid double PHY > initialization"). However, the devm_phy_optional_get() call has been kept > so the driver still gets the PHY even though it is not used for anything > in the driver. > > Drop the remaining code, and also remove the 'phy' member of the > 'orion_ehci_hcd' structure to simplify the code. > > Fixes: e04585184dcf ("usb: ehci-orion: avoid double PHY initialization") The fixes tag makes no sense here, this is pure cleanup. I do not remember if this was needed or not, it is probably safe to drop today. Cheers, Miqu=C3=A8l