linux-next: build failure after merge of the mtd tree

linux-next: build failure after merge of the mtd tree

[Stephen Rothwell]

Hi David,

After merging the mtd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mtd/sm_ftl.c: In function 'sm_cache_flush':
drivers/mtd/sm_ftl.c:937: error: implicit declaration of function 'for_each_bit'
drivers/mtd/sm_ftl.c:938: error: expected ';' before '{' token
drivers/mtd/sm_ftl.c:964: error: label 'restart' used but not defined

OK, not a suprise since Andrew submitted the "remove for_each_bit" patch
and you haven't applied the patch below to the mtd tree.  Commit
7d17c02a01a111f40986859f044c8c4cce8a4aa6 ("mtd: Add new SmartMedia/xD
FTL") introduces a new use of "for_each_bit".  I have applied the below
patch for today, please add it to the mtd tree ASAP.

Subject: [patch 1/1] bitops: rename for_each_bit() to for_each_set_bit(): mtd
To: dwmw2@infradead.org
Cc: akpm@linux-foundation.org, akinobu.mita@gmail.com, adobriyan@gmail.com,
        davem@davemloft.net, dedekind@infradead.org, rmk@arm.linux.org.uk,
        sfr@canb.auug.org.au
From: akpm@linux-foundation.org
Date: Mon, 05 Apr 2010 13:53:35 -0700

From: Akinobu Mita <akinobu.mita@gmail.com>

Rename for_each_bit() to for_each_set_bit in the kernel source tree.  To
permit for_each_clear_bit(), should that ever be added.

I'll be sending a patch to Linus this week which removes the temporary
for_each_bit() macro, so this patch will be needed to avoid build
breakage.

Suggested-by: Alexey Dobriyan <adobriyan@gmail.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <dedekind@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mtd/sm_ftl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/mtd/sm_ftl.c~bitops-rename-for_each_bit-to-for_each_set_bit-mtd drivers/mtd/sm_ftl.c
--- a/drivers/mtd/sm_ftl.c~bitops-rename-for_each_bit-to-for_each_set_bit-mtd
+++ a/drivers/mtd/sm_ftl.c
@@ -934,7 +934,7 @@ int sm_cache_flush(struct sm_ftl *ftl)
 
 
 	/* Try to read all unread areas of the cache block*/
-	for_each_bit(sector_num, &ftl->cache_data_invalid_bitmap,
+	for_each_set_bit(sector_num, &ftl->cache_data_invalid_bitmap,
 		ftl->block_size / SM_SECTOR_SIZE) {
 
 		if (!sm_read_sector(ftl,
_

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the mtd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi all,

After merging the mtd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/mtd/parsers/bcm4908-partitions.o
ERROR: modpost: "bcm4908_partitions_post_parse" [drivers/mtd/parsers/ofpart.ko] undefined!

Caused by commit

  09cf6ee6d21c ("mtd: parsers: ofpart: support BCM4908 fixed partitions")

I have used the mtd tree from next-20210212 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mtd tree

[Rafał Miłecki]

Hi Stephen!

On 15.02.2021 02:28, Stephen Rothwell wrote:
> After merging the mtd tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/mtd/parsers/bcm4908-partitions.o
> ERROR: modpost: "bcm4908_partitions_post_parse" [drivers/mtd/parsers/ofpart.ko] undefined!
> 
> Caused by commit
> 
>    09cf6ee6d21c ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
> 
> I have used the mtd tree from next-20210212 for today.

Thank you for the report!

It has been fixed by the
[PATCH] mtd: parsers: ofpart: fix building as module
https://patchwork.ozlabs.org/project/linux-mtd/patch/20210215072844.16136-1-zajec5@gmail.com/
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=mtd/next&id=bc6dcf44da2bea215ae3edbdac5d350e96de3996

linux-next: build failure after merge of the mtd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi all,

After merging the mtd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "mtd_virt_concat_node_create" [drivers/mtd/mtd.ko] undefined!
ERROR: modpost: "mtd_virt_concat_add" [drivers/mtd/mtd.ko] undefined!
ERROR: modpost: "mtd_virt_concat_create_join" [drivers/mtd/mtd.ko] undefined!
ERROR: modpost: "mtd_virt_concat_destroy" [drivers/mtd/mtd.ko] undefined!

Caused by commit

  fa47dc829519 ("mtd: Add driver for concatenating devices")

I have used the mtd tree from next-20250901 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build failure after merge of the mtd tree

[Mahapatra, Amit Kumar]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello Stephen,

Could you please share the tree you are using along with the build steps you followed that resulted in this issue?

Regards,
Amit

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Tuesday, September 2, 2025 7:39 AM
> To: Richard Weinberger <richard.weinberger@gmail.com>
> Cc: Mahapatra, Amit Kumar <amit.kumar-mahapatra@amd.com>; Miquel Raynal
> <miquel.raynal@bootlin.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: linux-next: build failure after merge of the mtd tree
>
> Hi all,
>
> After merging the mtd tree, today's linux-next build (x86_64 allmodconfig) failed like
> this:
>
> ERROR: modpost: "mtd_virt_concat_node_create" [drivers/mtd/mtd.ko] undefined!
> ERROR: modpost: "mtd_virt_concat_add" [drivers/mtd/mtd.ko] undefined!
> ERROR: modpost: "mtd_virt_concat_create_join" [drivers/mtd/mtd.ko] undefined!
> ERROR: modpost: "mtd_virt_concat_destroy" [drivers/mtd/mtd.ko] undefined!
>
> Caused by commit
>
>   fa47dc829519 ("mtd: Add driver for concatenating devices")
>
> I have used the mtd tree from next-20250901 for today.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the mtd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi Amit,

On Tue, 2 Sep 2025 05:25:04 +0000 "Mahapatra, Amit Kumar" <amit.kumar-mahapatra@amd.com> wrote:
>
> Could you please share the tree you are using along with the build
> steps you followed that resulted in this issue?

https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch mtd/next

I just did an x86_64 allmodconfig build.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mtd tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi all,

After merging the mtd tree, today's linux-next build (arm64 defconfig)
failed like this:

ld: Unexpected GOT/PLT entries detected!
ld: Unexpected run-time procedure linkages detected!
ld: drivers/mtd/mtdcore.o: in function `cleanup_mtd':
/tmp/next/build/drivers/mtd/mtdcore.c:2641:(.exit.text+0x18): undefined reference to `mtd_virt_concat_destroy_joins'
ld: /tmp/next/build/drivers/mtd/mtdcore.c:2642:(.exit.text+0x1c): undefined reference to `mtd_virt_concat_destroy_items'

Caused by commit

  285871f1ff3c2 (mtd: Add driver for concatenating devices)

I have used the version from next-20260129 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mtd tree

[Miquel Raynal]

Hi,

On 30/01/2026 at 15:47:07 GMT, Mark Brown <broonie@kernel.org> wrote:

> Hi all,
>
> After merging the mtd tree, today's linux-next build (arm64 defconfig)
> failed like this:
>
> ld: Unexpected GOT/PLT entries detected!
> ld: Unexpected run-time procedure linkages detected!
> ld: drivers/mtd/mtdcore.o: in function `cleanup_mtd':
> /tmp/next/build/drivers/mtd/mtdcore.c:2641:(.exit.text+0x18): undefined reference to `mtd_virt_concat_destroy_joins'
> ld: /tmp/next/build/drivers/mtd/mtdcore.c:2642:(.exit.text+0x1c): undefined reference to `mtd_virt_concat_destroy_items'
>
> Caused by commit
>
>   285871f1ff3c2 (mtd: Add driver for concatenating devices)
>
> I have used the version from next-20260129 instead.

Sorry for that, I believe I removed it on Thursday evening due to some
robot report, but it already reached -next.

Cheers,
Miquèl

linux-next: build failure after merge of the mtd tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hi all,

After merging the mtd tree, today's linux-next build (KCONFIG_NAME)
failed like this:

/tmp/next/build/drivers/mtd/maps/physmap-core.c: In function 'physmap_flash_of_init':
/tmp/next/build/drivers/mtd/maps/physmap-core.c:367:23: error: implicit declaration of function 'of_flash_probe_bt1_rom'; did you mean 'of_flash_probe_ixp4xx'? [-Wimplicit-function-declaration]
  367 |                 err = of_flash_probe_bt1_rom(dev, dp, &info->maps[i]);
      |                       ^~~~~~~~~~~~~~~~~~~~~~
      |                       of_flash_probe_ixp4xx

Caused by commit

   16d68d10f5b93 (mtd: physmap: physmap-bt1-rom: Remove not-going-to-be-supported code for Baikal SoC)

I have used the version from 20260311 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mtd tree

[Andy Shevchenko]

On Thu, Mar 12, 2026 at 01:14:17PM +0000, Mark Brown wrote:
> Hi all,
> 
> After merging the mtd tree, today's linux-next build (KCONFIG_NAME)
> failed like this:
> 
> /tmp/next/build/drivers/mtd/maps/physmap-core.c: In function 'physmap_flash_of_init':
> /tmp/next/build/drivers/mtd/maps/physmap-core.c:367:23: error: implicit declaration of function 'of_flash_probe_bt1_rom'; did you mean 'of_flash_probe_ixp4xx'? [-Wimplicit-function-declaration]
>   367 |                 err = of_flash_probe_bt1_rom(dev, dp, &info->maps[i]);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~
>       |                       of_flash_probe_ixp4xx
> 
> Caused by commit
> 
>    16d68d10f5b93 (mtd: physmap: physmap-bt1-rom: Remove not-going-to-be-supported code for Baikal SoC)
> 
> I have used the version from 20260311 instead.

Yeah, sorry for that, I will send a follow up that may be applied on top or
squashed with the original change.

-- 
With Best Regards,
Andy Shevchenko