public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nam Cao <namcao@linutronix.de>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Checkpatch false positive: externs should be avoided in .c files
Date: Mon, 02 Feb 2026 13:05:08 +0100	[thread overview]
Message-ID: <875x8fz6yz.fsf@yellow.woof> (raw)

Hi,

checkpatch seems to give a wrong warning about this patch:
https://lore.kernel.org/linux-riscv/20260202115403.2119218-1-namcao@linutronix.de/T/#u

WARNING: externs should be avoided in .c files
#663: FILE: arch/riscv/kernel/setup.c:49:
+atomic_t hart_lottery __section(".sdata");

I think this is wrong, because 'extern' does not even appear anywhere in
that part of the diff.

I attempted to look into checkpatch, but my perl knowledge is not
sufficient to dig deeper into this issue. Can you please have a look?

Best regards,
Nam

             reply	other threads:[~2026-02-02 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 12:05 Nam Cao [this message]
2026-02-02 15:24 ` Checkpatch false positive: externs should be avoided in .c files Joe Perches
2026-02-03  5:57 ` Joe Perches
2026-02-04  7:28   ` Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x8fz6yz.fsf@yellow.woof \
    --to=namcao@linutronix.de \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox