From: Thomas Gleixner <tglx@kernel.org>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
chenhuacai@kernel.org, kernel@xen0n.name, corbet@lwn.net,
alexs@kernel.org, si.yanteng@linux.dev, jiaxun.yang@flygoat.com,
maobibo@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tianyang Zhang <zhangtianyang@loongson.cn>
Subject: Re: [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h preparation for Redirect irqchip
Date: Fri, 30 Jan 2026 09:14:07 +0100 [thread overview]
Message-ID: <875x8jmsa8.ffs@tglx> (raw)
In-Reply-To: <20260130025941.2140582-3-zhangtianyang@loongson.cn>
On Fri, Jan 30 2026 at 10:59, Tianyang Zhang wrote:
The subject line is broken and incomprehensible. Something like:
irqchip/irq-loonarch-avec: Prepare for interrupt redirection support
is concise and gives context.
> Adjusted definitions and macro from loongson-avec.c to irq-loongson.h,
> including:
> 1 marco AVEC_MSG_OFFSET
> 2 struct avecintc_data
> 3 Make avecintc_sync public
That's not a change log because it only tells _what_ the patch is doing,
but not _why_. Enumerating the details of what is moved is a pointless
exercise because that can bee seen from the diff itself.
So you want something like:
Interrupt redirection support requires a new interrupt chip, which
needs to share data structures, constants and functions with the AVEC
code.
Move them to the header file and make the required functions public.
See?
next prev parent reply other threads:[~2026-01-30 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 2:59 [PATCH v9 0/4] Loongarch irq-redirect support Tianyang Zhang
2026-01-30 2:59 ` [PATCH v9 1/4] Docs/LoongArch: Add Advanced Extended-Redirect IRQ model description Tianyang Zhang
2026-01-30 2:59 ` [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h preparation for Redirect irqchip Tianyang Zhang
2026-01-30 8:14 ` Thomas Gleixner [this message]
2026-01-30 2:59 ` [PATCH v9 3/4] irqchip/loongarch-avec.c:return IRQ_SET_MASK_OK_DONE when keep affinity Tianyang Zhang
2026-01-30 8:20 ` Thomas Gleixner
2026-01-30 9:05 ` Tianyang Zhang
2026-01-30 2:59 ` [PATCH v9 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang
2026-01-30 8:33 ` kernel test robot
2026-01-30 8:54 ` Thomas Gleixner
2026-02-02 1:00 ` Tianyang Zhang
-- strict thread matches above, loose matches on Subject: below --
2026-01-30 2:55 [PATCH v9 0/4] Loongarch irq-redirect support Tianyang Zhang
2026-01-30 2:55 ` [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h preparation for Redirect irqchip Tianyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x8jmsa8.ffs@tglx \
--to=tglx@kernel.org \
--cc=alexs@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=si.yanteng@linux.dev \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox