From: Takashi Iwai <tiwai@suse.de>
To: Baojun Xu <baojun.xu@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<alsa-devel@alsa-project.org>, <shenghao-ding@ti.com>,
<navada@ti.com>, <13916275206@139.com>, <v-hampiholi@ti.com>,
<v-po@ti.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
Date: Thu, 03 Jul 2025 11:41:44 +0200 [thread overview]
Message-ID: <875xg9obl3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250703000608.20815-1-baojun.xu@ti.com>
On Thu, 03 Jul 2025 02:06:08 +0200,
Baojun Xu wrote:
>
> Device name start from bus name, as we use strstarts()
> to do compare, need add it for TXNW2781 device.
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Could you give the proper Fixes tag if it's a fix of the previous
changes?
thanks,
Takashi
> ---
> sound/pci/hda/tas2781_hda_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
> index b9cdbca95..530c2266a 100644
> --- a/sound/pci/hda/tas2781_hda_i2c.c
> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
> hda_priv->save_calibration = tas2781_save_calibration;
> tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
> } else if (strstarts(dev_name(&clt->dev),
> - "TXNW2781:00-tas2781-hda.0")) {
> + "i2c-TXNW2781:00-tas2781-hda.0")) {
> device_name = "TXNW2781";
> hda_priv->save_calibration = tas2781_save_calibration;
> tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-07-03 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 0:06 [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check Baojun Xu
2025-07-03 9:41 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-05 2:53 Baojun Xu
2025-07-06 8:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xg9obl3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=shenghao-ding@ti.com \
--cc=v-hampiholi@ti.com \
--cc=v-po@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox