Re: [PATCH v6 6/6] timers: Exclude isolated cpus from timer migation

Frederic Weisbecker
2025-06-25T14:42:23Z

Le Wed, Jun 25, 2025 at 03:46:02PM +0200, Gabriele Monaco a écrit :
> Thanks both for the reviews.
> I'm a bit puzzled by what is expected now, though.
>
> The late initcall would work just fine to replace the call to
> tick_nohz_cpu_hotpluggable(), indeed superfluous for hotplug calls,
> however the checks for housekeeping CPUs is required to prevent
> isolated CPUs getting online from becoming available and so will run on
> early boot too (without any practical reason, only because the hotplug
> handlers run there).
>
> I might avoid it by playing with cpuhp_setup_state_nocalls perhaps, but
> that feels even more hacky.
>
> Otherwise, I can refactor the code to maintain a separate field
> (isolated), restore the 'online' field and keep the functions for
> online/offline and isolation as separate as possible, while considering
> available = !isolated && online
>
> This would make reading housekeeping masks superfluous on hotplug (and
> boot) code, but again, it doesn't look simpler to me.
>
> Am I missing some obviously elegant solution here?

I keep being confused as well but yes, I think you're right, we need to
keep the checks anyway on CPU up.

>
> Thanks,
> Gabriele
>

--
Frederic Weisbecker
SUSE Labs