From: Thomas Gleixner <tglx@linutronix.de>
To: Koichiro Den <koichiro.den@canonical.com>, linux-kernel@vger.kernel.org
Cc: anna-maria@linutronix.de, frederic@kernel.org, peterz@infradead.org
Subject: Re: [PATCH] hrtimer: reset .hres_active and .online at appropriate points
Date: Thu, 16 Jan 2025 10:24:07 +0100 [thread overview]
Message-ID: <875xmfaz7s.ffs@tglx> (raw)
In-Reply-To: <878qrbazki.ffs@tglx>
On Thu, Jan 16 2025 at 10:16, Thomas Gleixner wrote:
> On Fri, Dec 20 2024 at 22:44, Koichiro Den wrote:
>> Reset these fields at the appropriate points. Ideally, .hres_active
>> would be reset in tick_cpu_dying() as underlying clockevent is shut down
>> there. However, since these operations occur in the atomic AP section
>> with interrupts disabled in any case, this patch resets .hres_active to
>> 0 in hrtimers_cpu_dying() for simplicity.
>
> It does not matter where it is reset and from a hrtimer point of view
> the dying() callback is the appropriate place.
That said. The change is actually incomplete as the other fields which
are related to the per CPU base state are not reset either.
next prev parent reply other threads:[~2025-01-16 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 13:44 [PATCH] hrtimer: reset .hres_active and .online at appropriate points Koichiro Den
2025-01-16 9:08 ` Thomas Gleixner
2025-01-16 9:16 ` Thomas Gleixner
2025-01-16 9:24 ` Thomas Gleixner [this message]
2025-01-18 7:37 ` Koichiro Den
2025-01-16 9:50 ` [tip: timers/urgent] hrtimers: Handle CPU state correctly on hotplug tip-bot2 for Koichiro Den
2025-01-16 10:56 ` Borislav Petkov
2025-01-16 12:36 ` tip-bot2 for Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xmfaz7s.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=koichiro.den@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox