public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Benno Lossin" <benno.lossin@proton.me>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] rust: add global lock support
Date: Fri, 11 Oct 2024 16:57:47 +0200	[thread overview]
Message-ID: <875xpylmac.fsf@kernel.org> (raw)
In-Reply-To: <2376e7b3-42a4-4743-a5cd-83251dcc0075@proton.me> (Benno Lossin's message of "Thu, 10 Oct 2024 22:14:52 +0000")

"Benno Lossin" <benno.lossin@proton.me> writes:

> On 10.10.24 16:01, Andreas Hindborg wrote:
>> "Benno Lossin" <benno.lossin@proton.me> writes:
>>
>>>
>>> Also,
>>>
>>>     error: type `__static_lock_ty_VALUE` should have an upper camel case name
>>>        --> rust/kernel/sync/lock/global.rs:100:18
>>>         |
>>>     100 |               type [< __static_lock_ty_ $name >] = $valuety;
>>>         |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `StaticLockTyValue`
>>>
>>
>> How did you manage to get these errors?
>
> I added a `global_lock!` invocation to `lib.rs`. Otherwise I also don't
> get them (they might also be emitted from the examples, but I didn't
> compile those).

I build the examples for kunit, but I did not get any warnings.
Interesting.

BR Andreas


  reply	other threads:[~2024-10-14  9:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 13:11 [PATCH v4] rust: add global lock support Alice Ryhl
2024-10-10 10:39 ` Benno Lossin
2024-10-10 10:53   ` Alice Ryhl
2024-10-10 13:55     ` Boqun Feng
2024-10-10 13:58       ` Alice Ryhl
2024-10-10 14:29         ` Boqun Feng
2024-10-10 16:33           ` Boqun Feng
2024-10-10 22:21             ` Benno Lossin
2024-10-10 23:06               ` Boqun Feng
2024-10-11  7:01                 ` Benno Lossin
2024-10-11 22:43                   ` Boqun Feng
2024-10-10 22:13     ` Benno Lossin
2024-10-10 14:01   ` Andreas Hindborg
2024-10-10 22:14     ` Benno Lossin
2024-10-11 14:57       ` Andreas Hindborg [this message]
2024-10-10 13:57 ` Andreas Hindborg
2024-10-10 14:01   ` Alice Ryhl
2024-10-10 14:08     ` Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xpylmac.fsf@kernel.org \
    --to=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox