public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Max R <max8rr8@gmail.com>
Cc: tip-bot2 for Max Ramanouski <tip-bot2@linutronix.de>,
	linux-tip-commits@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Alistair Popple <apopple@nvidia.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/urgent] x86/ioremap: Use is_ioremap_addr() in iounmap()
Date: Wed, 21 Aug 2024 11:27:05 +0200	[thread overview]
Message-ID: <875xrujkeu.ffs@tglx> (raw)
In-Reply-To: <CAJrpu5n5ReFCWrtAYsWpneAb+g6hAs4E-NeFh40chJfArEsioQ@mail.gmail.com>

On Wed, Aug 21 2024 at 11:35, Max R. wrote:

Please do not top-post and trim your replies.

> Apparently,  x86-32 doesn't provide VMALLOC_START in asm/pgtable.h,
> and after a quick glance it seems to be the only arch to do so...
> Probably the correct solution is to add include asm/vmalloc.h to
> include/linux/ioremap.h, considering it uses VMALLOC_START. Will
> resubmit the v4 version of patch later today.

Careful, this might end up with other issues vs. the kernel header
inclusion hell.

If i386 is the only one which does not have VMALLOC start in
asm/pgtable.h, then curing this might be the easier fix, no?

Thanks,

        tglx

  reply	other threads:[~2024-08-21  9:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 20:56 [PATCH v3] x86/ioremap: Use is_ioremap_addr() in iounmap() Max Ramanouski
2024-08-15 22:55 ` Alistair Popple
2024-08-16  9:43 ` [tip: x86/urgent] " tip-bot2 for Max Ramanouski
2024-08-20 20:35   ` Thomas Gleixner
2024-08-21  8:35     ` Max R
2024-08-21  9:27       ` Thomas Gleixner [this message]
2024-08-21 21:21         ` Max Ramanouski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xrujkeu.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=apopple@nvidia.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=max8rr8@gmail.com \
    --cc=tip-bot2@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox