* [PATCH v2] drm: Add documentation for struct drm_pane_size_hint
@ 2024-08-01 13:01 abid-sayyad
2024-08-02 8:06 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: abid-sayyad @ 2024-08-01 13:01 UTC (permalink / raw)
To: airlied
Cc: daniel, maarten.lankhorst, mripard, tzimmermann, dri-devel,
linux-kernel, abid-sayyad
Fixed warning for the following:
./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
'width' not described in 'drm_plane_size_hint'
./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
'height' not described in 'drm_plane_size_hint'
Signed-off-by: abid-sayyad <sayyad.abid16@gmail.com>
---
My sincere apologies for the spam and the patch subject error
Changes in v2:
- Adress review feedback regarding indentation in the fix
- Link to v1
https://lore.kernel.org/all/20240801102239.572718-1-sayyad.abid16@gmail.com/
include/uapi/drm/drm_mode.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index d390011b89b4..9d398335d871 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -864,7 +864,13 @@ struct drm_color_lut {
* array of struct drm_plane_size_hint.
*/
struct drm_plane_size_hint {
+ /**
+ * @width: width of the plane in pixels.
+ */
__u16 width;
+ /**
+ * @height: height of the plane in pixels.
+ */
__u16 height;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm: Add documentation for struct drm_pane_size_hint
2024-08-01 13:01 [PATCH v2] drm: Add documentation for struct drm_pane_size_hint abid-sayyad
@ 2024-08-02 8:06 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-08-02 8:06 UTC (permalink / raw)
To: abid-sayyad, airlied
Cc: daniel, maarten.lankhorst, mripard, tzimmermann, dri-devel,
linux-kernel, abid-sayyad
On Thu, 01 Aug 2024, abid-sayyad <sayyad.abid16@gmail.com> wrote:
> Fixed warning for the following:
> ./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
> 'width' not described in 'drm_plane_size_hint'
> ./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
> 'height' not described in 'drm_plane_size_hint'
>
> Signed-off-by: abid-sayyad <sayyad.abid16@gmail.com>
> ---
> My sincere apologies for the spam and the patch subject error
Usually there's no need to resend, at least not immediately, because of
issues in the subject or the commit message. Many of them can be fixed
while applying, and if not, you'll be asked to fix and resend.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Changes in v2:
> - Adress review feedback regarding indentation in the fix
> - Link to v1
> https://lore.kernel.org/all/20240801102239.572718-1-sayyad.abid16@gmail.com/
>
> include/uapi/drm/drm_mode.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index d390011b89b4..9d398335d871 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -864,7 +864,13 @@ struct drm_color_lut {
> * array of struct drm_plane_size_hint.
> */
> struct drm_plane_size_hint {
> + /**
> + * @width: width of the plane in pixels.
> + */
> __u16 width;
> + /**
> + * @height: height of the plane in pixels.
> + */
> __u16 height;
> };
>
> --
> 2.39.2
>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 13:01 [PATCH v2] drm: Add documentation for struct drm_pane_size_hint abid-sayyad
2024-08-02 8:06 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox