From: Takashi Iwai <tiwai@suse.de>
To: Baojun Xu <baojun.xu@ti.com>
Cc: <robh+dt@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<lgirdwood@gmail.com>, <perex@perex.cz>,
<pierre-louis.bossart@linux.intel.com>, <kevin-lu@ti.com>,
<shenghao-ding@ti.com>, <navada@ti.com>, <13916275206@139.com>,
<v-hampiholi@ti.com>, <v-po@ti.com>, <niranjan.hy@ti.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<liam.r.girdwood@intel.com>, <yung-chuan.liao@linux.intel.com>,
<broonie@kernel.org>, <soyer@irl.hu>
Subject: Re: [PATCH v7 1/1] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI
Date: Thu, 13 Jun 2024 14:36:33 +0200 [thread overview]
Message-ID: <875xudnhny.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240613082633.388-2-baojun.xu@ti.com>
On Thu, 13 Jun 2024 10:26:33 +0200,
Baojun Xu wrote:
> --- a/sound/pci/hda/Makefile
> +++ b/sound/pci/hda/Makefile
> @@ -70,6 +70,8 @@ obj-$(CONFIG_SND_HDA_SCODEC_CS35L56_SPI) += snd-hda-scodec-cs35l56-spi.o
> obj-$(CONFIG_SND_HDA_CS_DSP_CONTROLS) += snd-hda-cs-dsp-ctls.o
> obj-$(CONFIG_SND_HDA_SCODEC_COMPONENT) += snd-hda-scodec-component.o
> obj-$(CONFIG_SND_HDA_SCODEC_TAS2781_I2C) += snd-hda-scodec-tas2781-i2c.o
> +obj-$(CONFIG_SND_HDA_SCODEC_TAS2781_SPI) += snd-hda-scodec-tas2781-spi.o
> +snd-hda-scodec-tas2781-spi-y := tas2781_hda_spi.o tas2781_spi_fwlib.o
Try to put *-y addition to the right place. There are the section
defining snd-hda-codec-*-y.
> +#define TASDEVICE_REG(book, page, reg) (((book & GENMASK(7, 0)) << 16) + \
> + ((page & GENMASK(7, 0)) << 8) + \
> + ((reg & GENMASK(6, 0)) << 1))
Usually bits are combined with '|', not '+'.
> +/* Firmware block Checksum */
> +#define TASDEVICE_Checksum TASDEVICE_REG(0x0, 0x0, 0x7e)
Use capital letters.
... and at this point, I noticed that the patch doesn't contain the
code for sound/pci/hda/tas2781_spi_fwlib.c at all. The patch must be
utterly broken.
*PLEASE* try to apply and build the patch to submit beforehand from
the clean state and verify it really works.
thanks,
Takashi
next prev parent reply other threads:[~2024-06-13 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 8:26 [PATCH v7 0/1] Add tas2781 driver for SPI Baojun Xu
2024-06-13 8:26 ` [PATCH v7 1/1] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI Baojun Xu
2024-06-13 12:36 ` Takashi Iwai [this message]
2024-06-13 12:23 ` [PATCH v7 0/1] Add tas2781 driver for SPI Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xudnhny.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=v-hampiholi@ti.com \
--cc=v-po@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox