public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Li zeming <zeming@nfschina.com>, jstultz@google.com, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: Re: [PATCH] time: ntp: Remove unnecessary ‘-ENODEV’ values from err
Date: Mon, 26 Jun 2023 22:53:24 +0200	[thread overview]
Message-ID: <875y7a54jf.ffs@tglx> (raw)
In-Reply-To: <20230627182540.5243-1-zeming@nfschina.com>

On Wed, Jun 28 2023 at 02:25, Li zeming wrote:
> err is assigned first, so it does not need to initialize the
> assignment.

I don't know how you or the broken tool you rely upon came to that
conclusion.

There is clearly an error exit path which proves you wrong.

Please look at your changes and compile them before posting. There are
existing tools which do a better job than that.

Thanks,

        tglx

      parent reply	other threads:[~2023-06-26 20:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 18:25 [PATCH] time: ntp: Remove unnecessary ‘-ENODEV’ values from err Li zeming
2023-06-26  4:05 ` kernel test robot
2023-06-26  4:05 ` kernel test robot
2023-06-26 20:53 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y7a54jf.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=zeming@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox