From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DB1C77B61 for ; Tue, 25 Apr 2023 14:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234437AbjDYOSp (ORCPT ); Tue, 25 Apr 2023 10:18:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234368AbjDYOSn (ORCPT ); Tue, 25 Apr 2023 10:18:43 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68E7115479 for ; Tue, 25 Apr 2023 07:18:15 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CAF6C219B9; Tue, 25 Apr 2023 14:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682432265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vu12ON/WesxlB0hJUtT2BAKm7J4iDSBHK3E7w7ezOa8=; b=G3Giaw2g2Rgwxsvklqei7cjg1zNpYrv5GUvC0SuvY7Eee8ybL5VbUob+c5WySTaqO2a2CV bGUmgxESm+U412hv/2bF3BrisuyDMV4H92zO3teUW21XyjNELj7KjceamHu6K3lmNj4d35 k2wTllKpyPwtGsvqwbEBFSKBnDVdQRw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682432265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vu12ON/WesxlB0hJUtT2BAKm7J4iDSBHK3E7w7ezOa8=; b=642G+HuBISPdlEa06vvW/zGwzFhniASkCXNDqJSCzxPULrQSt8THbI/XA+8Uj7zkjhXWaI x5ed+EPmFmD8vlAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A28EE138E3; Tue, 25 Apr 2023 14:17:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JFruJgnhR2TgMwAAMHmgww (envelope-from ); Tue, 25 Apr 2023 14:17:45 +0000 Date: Tue, 25 Apr 2023 16:17:45 +0200 Message-ID: <875y9kujue.wl-tiwai@suse.de> From: Takashi Iwai To: Reaper Li Cc: , , , , jasontao Subject: Re: [PATCH v2] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs. In-Reply-To: <20230425101524.8020-1-reaperlioc@glenfly.com> References: <20230425101524.8020-1-reaperlioc@glenfly.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Apr 2023 12:15:24 +0200, Reaper Li wrote: > > From: jasontao > > Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for > Glenfly Gpus. > > - In default_bdl_pos_adj, set bdl to 128 as Glenfly Gpus have hardware > limitation, need to increase hdac interrupt interval. > - In azx_first_init, enable polling mode for Glenfly Gpu. When the codec > complete the command, it sends interrupt and writes response entries to > memory, howerver, the write requests sometimes are not actually > synchronized to memory when driver handle hdac interrupt on Glenfly Gpus. > If the RIRB status is not updated in the interrupt handler, > azx_rirb_get_response keeps trying to recevie a response from rirb until > 1s timeout. Enabling polling mode for Glenfly Gpu can fix the issue. > - In patch_gf_hdmi, set Glenlfy Gpu Codec's no_sticky_stream as it need > driver to do actual clean-ups for the linked codec when switch from one > codec to another. > > Signed-off-by: jasontao > Signed-off-by: Reaper Li > --- > v2: add some comments for code and details in the commit log. This is almost fine, but could just correct minor warnings scripts/checkpatch.pl complains? thanks, Takashi