From: Takashi Iwai <tiwai@suse.de>
To: ReaperLi <ReaperLi@glenfly.com>
Cc: <perex@perex.cz>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>, jasontao <jasontao@glenfly.com>
Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.
Date: Fri, 14 Apr 2023 11:39:17 +0200 [thread overview]
Message-ID: <875y9yn6pm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230414085055.27323-1-ReaperLi@glenfly.com>
On Fri, 14 Apr 2023 10:50:55 +0200,
ReaperLi wrote:
>
> From: jasontao <jasontao@glenfly.com>
>
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Arise.
>
> Signed-off-by: jasontao <jasontao@glenfly.com>
Your Signed-off-by tag seems missing. The person who submitted the
patch must give the own Signed-off-by tag. That's a legal
requirement.
Moreover, the patch doesn't seem applicable with git-am. Please fix
your mailer setup to stop mangling tabs with spaces.
At best, use git-send-email for submission.
If anything else can't work, use a mail attachment as a last resort.
The code change itself looks good to me. Please resubmit for the
above points.
thanks,
Takashi
next prev parent reply other threads:[~2023-04-14 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:50 [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs ReaperLi
2023-04-14 9:39 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-18 8:23 reaperli
2023-04-18 8:33 reaperli
2023-04-18 9:44 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9yn6pm.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=ReaperLi@glenfly.com \
--cc=jasontao@glenfly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox