From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AACC77B6F for ; Fri, 14 Apr 2023 09:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbjDNJjc (ORCPT ); Fri, 14 Apr 2023 05:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbjDNJja (ORCPT ); Fri, 14 Apr 2023 05:39:30 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5B634EFB for ; Fri, 14 Apr 2023 02:39:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DA948219D0; Fri, 14 Apr 2023 09:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681465157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=skf3seKEe0wZbWPgQrr1I7/5atIccPr0kK0oGXYSgcc=; b=LsKGHmFaenlaL8ZucxrnOIfsa+0SB/WIS+TnjHXehc9i8dnluFiBeO1CbNDiSX4JJF/bFf Hmn+sxPTOgRDEuIJLuIogtzPaQapcYF3VBjY3fqetRCVd1r+YioDiD+cWXmIJTr7HL94v8 CKQ+5QHXezgjd5IcW3Sa/mkqyHEyLhU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681465157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=skf3seKEe0wZbWPgQrr1I7/5atIccPr0kK0oGXYSgcc=; b=OI7qLHocoCoGmAZskvb2Y1SxNhNpCfsSMlbdyjaiVcYnjEj3P31rc0V9CZOyLAfRLzFPqA zkxPmvFuIB2tmfDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B565413498; Fri, 14 Apr 2023 09:39:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0VWBK0UfOWRRDwAAMHmgww (envelope-from ); Fri, 14 Apr 2023 09:39:17 +0000 Date: Fri, 14 Apr 2023 11:39:17 +0200 Message-ID: <875y9yn6pm.wl-tiwai@suse.de> From: Takashi Iwai To: ReaperLi Cc: , , , jasontao Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs. In-Reply-To: <20230414085055.27323-1-ReaperLi@glenfly.com> References: <20230414085055.27323-1-ReaperLi@glenfly.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Apr 2023 10:50:55 +0200, ReaperLi wrote: > > From: jasontao > > Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for > Glenfly Arise. > > Signed-off-by: jasontao Your Signed-off-by tag seems missing. The person who submitted the patch must give the own Signed-off-by tag. That's a legal requirement. Moreover, the patch doesn't seem applicable with git-am. Please fix your mailer setup to stop mangling tabs with spaces. At best, use git-send-email for submission. If anything else can't work, use a mail attachment as a last resort. The code change itself looks good to me. Please resubmit for the above points. thanks, Takashi