From: Jani Nikula <jani.nikula@linux.intel.com>
To: Hamza Mahfooz <someguy@effective-light.com>,
linux-kernel@vger.kernel.org
Cc: Hamza Mahfooz <someguy@effective-light.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Allen Chen <allen.chen@ite.com.tw>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Hermes Wu <hermes.wu@ite.com.tw>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()
Date: Mon, 12 Sep 2022 11:08:19 +0300 [thread overview]
Message-ID: <875yht6mmk.fsf@intel.com> (raw)
In-Reply-To: <20220910224816.15058-1-someguy@effective-light.com>
On Sat, 10 Sep 2022, Hamza Mahfooz <someguy@effective-light.com> wrote:
> As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
> to __drm_debug to discourage use"), we shouldn't explicitly refer to
> __drm_debug in this context. So, use drm_debug_enabled() instead.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 4b673c4792d7..875f87c576cb 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg,
> struct device *dev = &it6505->client->dev;
> int val;
>
> - if (likely(!(__drm_debug & DRM_UT_DRIVER)))
> + if (!drm_debug_enabled(DRM_UT_DRIVER))
> return;
>
> val = it6505_read(it6505, reg);
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-09-12 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 22:48 [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() Hamza Mahfooz
2022-09-12 8:08 ` Jani Nikula [this message]
2022-09-12 10:30 ` AngeloGioacchino Del Regno
2022-09-12 11:45 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yht6mmk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hermes.wu@ite.com.tw \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox