* [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()
@ 2022-09-10 22:48 Hamza Mahfooz
2022-09-12 8:08 ` Jani Nikula
2022-09-12 10:30 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 4+ messages in thread
From: Hamza Mahfooz @ 2022-09-10 22:48 UTC (permalink / raw)
To: linux-kernel
Cc: Hamza Mahfooz, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, AngeloGioacchino Del Regno, Hermes Wu, Allen Chen,
dri-devel
As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
to __drm_debug to discourage use"), we shouldn't explicitly refer to
__drm_debug in this context. So, use drm_debug_enabled() instead.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
---
drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..875f87c576cb 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg,
struct device *dev = &it6505->client->dev;
int val;
- if (likely(!(__drm_debug & DRM_UT_DRIVER)))
+ if (!drm_debug_enabled(DRM_UT_DRIVER))
return;
val = it6505_read(it6505, reg);
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()
2022-09-10 22:48 [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() Hamza Mahfooz
@ 2022-09-12 8:08 ` Jani Nikula
2022-09-12 10:30 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2022-09-12 8:08 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Hamza Mahfooz, Jernej Skrabec, Jonas Karlman, David Airlie,
Allen Chen, dri-devel, Neil Armstrong, Robert Foss, Hermes Wu,
Laurent Pinchart, Andrzej Hajda, AngeloGioacchino Del Regno
On Sat, 10 Sep 2022, Hamza Mahfooz <someguy@effective-light.com> wrote:
> As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
> to __drm_debug to discourage use"), we shouldn't explicitly refer to
> __drm_debug in this context. So, use drm_debug_enabled() instead.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 4b673c4792d7..875f87c576cb 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg,
> struct device *dev = &it6505->client->dev;
> int val;
>
> - if (likely(!(__drm_debug & DRM_UT_DRIVER)))
> + if (!drm_debug_enabled(DRM_UT_DRIVER))
> return;
>
> val = it6505_read(it6505, reg);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()
2022-09-10 22:48 [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() Hamza Mahfooz
2022-09-12 8:08 ` Jani Nikula
@ 2022-09-12 10:30 ` AngeloGioacchino Del Regno
2022-09-12 11:45 ` Robert Foss
1 sibling, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-12 10:30 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hermes Wu, Allen Chen, dri-devel
Il 11/09/22 00:48, Hamza Mahfooz ha scritto:
> As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
> to __drm_debug to discourage use"), we shouldn't explicitly refer to
> __drm_debug in this context. So, use drm_debug_enabled() instead.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()
2022-09-12 10:30 ` AngeloGioacchino Del Regno
@ 2022-09-12 11:45 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2022-09-12 11:45 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Hamza Mahfooz, linux-kernel, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Hermes Wu, Allen Chen, dri-devel
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-12 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-10 22:48 [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() Hamza Mahfooz
2022-09-12 8:08 ` Jani Nikula
2022-09-12 10:30 ` AngeloGioacchino Del Regno
2022-09-12 11:45 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox