From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Lucas Tanure <tanureal@opensource.cirrus.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/2] ALSA: hda: cs35l41: Call put_device() in the scope of get_device()
Date: Tue, 06 Sep 2022 14:01:27 +0200 [thread overview]
Message-ID: <875yi0hfu0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220905165826.35979-1-andriy.shevchenko@linux.intel.com>
On Mon, 05 Sep 2022 18:58:25 +0200,
Andy Shevchenko wrote:
>
> When put_device() is called in another function it's hard to realize
> that and easy to "fix" the code in a wrong way. Instead, move
> put_device() to be in the same scope as get_device(), so we prevent
> appearance of any attempts to "fix" the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied both patches now. Thanks.
Takashi
prev parent reply other threads:[~2022-09-06 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 16:58 [PATCH v1 1/2] ALSA: hda: cs35l41: Call put_device() in the scope of get_device() Andy Shevchenko
2022-09-05 16:58 ` [PATCH v1 2/2] ALSA: hda: cs35l41: Utilize acpi_get_subsystem_id() Andy Shevchenko
2022-09-06 12:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yi0hfu0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox