From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDB8ECAAD8 for ; Tue, 30 Aug 2022 07:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiH3HcY (ORCPT ); Tue, 30 Aug 2022 03:32:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbiH3HcF (ORCPT ); Tue, 30 Aug 2022 03:32:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CE6D5A88B for ; Tue, 30 Aug 2022 00:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661844722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OOVt4IExjzgPDgf7VEi0MGTcB1ysxhPeqK70kuHJ9WU=; b=PgbZ21vyZAoNTKi8Sm/aK8OuoLL375xcukdxwB1q/CiSfBeNVCqARyni+ZMyhfcZ1tZU7Q CSu/SQgw0+T61cLCJpmiCDIN5mLNUEog7BbvZYiAE1A+1FyhlVxyGc2LoXavi5dEFTC+ec vbpkyFx4kdkzllo1JCNPQEOPB1HLE/k= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-445-UoYerASSOPeuIJY-pm_mtg-1; Tue, 30 Aug 2022 03:31:57 -0400 X-MC-Unique: UoYerASSOPeuIJY-pm_mtg-1 Received: by mail-ej1-f69.google.com with SMTP id qw34-20020a1709066a2200b00730ca5a94bfso3440743ejc.3 for ; Tue, 30 Aug 2022 00:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=OOVt4IExjzgPDgf7VEi0MGTcB1ysxhPeqK70kuHJ9WU=; b=FnMne8i/TWIWCe4w11HKsvzJ2cM6uuG6s90SIlhhn0QnbGKv9NFIky5ph3nxv2mMJG lnI9Lc119rn1IZTLt2KI5OHR5U24RLdh7lt2HNogguAgI91SI7KRknjmKb8DO4uHD2Er L2CHC2XcEwRueufNS711ffqzSRDKEd75rJ/0fqhCNyA2Y4MFW5F3urBDRWTDktZQkYp2 HGedt+BYYsPJZO0FsBPjjhzM2WlvTaZzmrPej6cmimqa0hrunlk+cXlgziMWFA0Y1yC+ PxR9E2syWRWGWxfNKnRK1afsexpZ/dqAe94FUjNYjUNnOai/9SUDZjRsqTmjg2jH68vC LjfQ== X-Gm-Message-State: ACgBeo1MBs3/BO8Y5FnWDoOGRmuCFcc6t5uMjQUYSUqvjGLrTzDvY3dF IhWfHBBMf0HD1qB05Ng3mSifaEpErVZeeTv83JgpU5bhWK3hKRqarQ133Q6+GJdOHF34DNgf+2W 5ytmMWV3VjvLQYZsquZ9Dt+jX X-Received: by 2002:a05:6402:40c3:b0:442:d798:48ad with SMTP id z3-20020a05640240c300b00442d79848admr19117000edb.154.1661844716127; Tue, 30 Aug 2022 00:31:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR5geuesvzHhVoqBxInKeA8loMmBCSHKoxr3j6EnwNKzcho7wEaeR3bBW9svuet4LzxXa/fI2w== X-Received: by 2002:a05:6402:40c3:b0:442:d798:48ad with SMTP id z3-20020a05640240c300b00442d79848admr19116988edb.154.1661844715957; Tue, 30 Aug 2022 00:31:55 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id r1-20020a1709061ba100b00731745a7e62sm5367557ejg.28.2022.08.30.00.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 00:31:55 -0700 (PDT) From: Vitaly Kuznetsov To: Wei Liu Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Deepak Rawat , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Michael Kelley Subject: Re: [PATCH v3 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h In-Reply-To: <20220829171508.GA8481@bhelgaas> References: <20220829171508.GA8481@bhelgaas> Date: Tue, 30 Aug 2022 09:31:54 +0200 Message-ID: <875yiauqz9.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn Helgaas writes: > On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: >> There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT >> and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these >> from core Vmbus code. Move the defines where they belong. > > It's a minor annoyance that the above is 81 characters long when "git > log" adds its 4-character indent, so it wraps in a default terminal. > > It'd be nice if we could settle on a conventional spelling of "Vmbus", > too. "Vmbus" looks to be in the minority: > > $ git grep Vmbus | wc -l; git grep VMbus | wc -l; git grep VMBus | wc -l > 4 > 82 > 62 > > FWIW, one published microsoft.com doc uses "VMBus": > https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/hyper-v-architecture Makes sense, Wei, assuming there are no other concerns about these patches, would you be able to tweak the commit message here when queueing or would you like me to send v4 instead? Thanks! -- Vitaly