From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41477C433EF for ; Sat, 23 Apr 2022 09:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234619AbiDWJqr (ORCPT ); Sat, 23 Apr 2022 05:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234603AbiDWJqo (ORCPT ); Sat, 23 Apr 2022 05:46:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D80D78937; Sat, 23 Apr 2022 02:43:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA6E160EDE; Sat, 23 Apr 2022 09:43:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C6CAC385A0; Sat, 23 Apr 2022 09:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650707027; bh=Lz9EJnShpChhsUOfGlRiZWzsOfwSCzPxuLGssgfvEwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nlv2ET/6t4D6e3sVZiFDXqnSujW84YVlYR+qrIegsH+rUcH9C86ie1g16158e5Zu7 kZEFQpKbAbGhId8Q9l5ElUEezMTFvXPiTaNbZcSXGXpdfRnR/+zd6bx6kOJVFiTeCy T5//EgW6rCw9UX4sPpbrPGStnkGKMKEnczust9dvWQKqW1cx+ceFMJd9ROTOgEPRfR dwAEjqLz/OH9oO22UK5SZOwWGaKBz3kDHAh5B7DImXEfosZsGuuPE0tfUwfjqIXsTY ayb+GanpOU+cVHalFzI+Fk66g7C+kHswewiwLxIS6E2x6Kw0DU3X4VYBwo6xMY4pUB 6NFEUm7D3C1ug== Received: from sofa.misterjones.org ([185.219.108.64] helo=billy-the-mountain.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1niCIq-006MPU-Q7; Sat, 23 Apr 2022 10:43:44 +0100 Date: Sat, 23 Apr 2022 10:43:44 +0100 Message-ID: <875yn0cey7.wl-maz@kernel.org> From: Marc Zyngier To: Krzysztof Kozlowski Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Thomas Gleixner , Andrew Jeffery , Eddie James , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH 1/2] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value In-Reply-To: <3eb57a4c-95b6-0bf5-aa1a-90ee2fd336e1@linaro.org> References: <20220422104536.61451-1-krzysztof.kozlowski@linaro.org> <3eb57a4c-95b6-0bf5-aa1a-90ee2fd336e1@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: krzysztof.kozlowski@linaro.org, brendanhiggins@google.com, benh@kernel.crashing.org, joel@jms.id.au, tglx@linutronix.de, andrew@aj.id.au, eajames@linux.ibm.com, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Apr 2022 10:30:53 +0100, Krzysztof Kozlowski wrote: > > On 22/04/2022 12:45, Krzysztof Kozlowski wrote: > > The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. > > > > Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed") > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/irqchip/irq-aspeed-i2c-ic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c > > index a47db16ff960..cef1291ae783 100644 > > --- a/drivers/irqchip/irq-aspeed-i2c-ic.c > > +++ b/drivers/irqchip/irq-aspeed-i2c-ic.c > > @@ -77,7 +77,7 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node, > > } > > > > i2c_ic->parent_irq = irq_of_parse_and_map(node, 0); > > - if (i2c_ic->parent_irq < 0) { > > + if (!i2c_ic->parent_irq) { > > ret = i2c_ic->parent_irq; > > This is wrong (same in patch 2). I will send a v2. While you're at it, please add a cover letter when sending a series containing more than a single patch. Thanks, M. -- Without deviation from the norm, progress is not possible.