* [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description
@ 2022-02-24 21:23 Andrew Halaney
2022-02-25 2:22 ` Boqun Feng
2022-03-04 17:13 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Halaney @ 2022-02-24 21:23 UTC (permalink / raw)
To: corbet
Cc: peterz, mingo, will, longman, boqun.feng, linux-doc, linux-kernel,
Andrew Halaney, Leah Leshchinsky
With PREEMPT_RT the _bh() version of a spinlock leaves preemption
enabled, align the doc to say that instead of the opposite.
Reported-by: Leah Leshchinsky <lleshchi@redhat.com>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Documentation/locking/locktypes.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
index 4fd7b70fcde1..bfa75ea1b66a 100644
--- a/Documentation/locking/locktypes.rst
+++ b/Documentation/locking/locktypes.rst
@@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
Non-PREEMPT_RT kernels disable preemption to get this effect.
PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
- preemption disabled. The lock disables softirq handlers and also
+ preemption enabled. The lock disables softirq handlers and also
prevents reentrancy due to task preemption.
PREEMPT_RT kernels preserve all other spinlock_t semantics:
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description
2022-02-24 21:23 [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description Andrew Halaney
@ 2022-02-25 2:22 ` Boqun Feng
2022-03-04 17:13 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Boqun Feng @ 2022-02-25 2:22 UTC (permalink / raw)
To: Andrew Halaney
Cc: corbet, peterz, mingo, will, longman, linux-doc, linux-kernel,
Leah Leshchinsky
On Thu, Feb 24, 2022 at 03:23:12PM -0600, Andrew Halaney wrote:
> With PREEMPT_RT the _bh() version of a spinlock leaves preemption
> enabled, align the doc to say that instead of the opposite.
>
> Reported-by: Leah Leshchinsky <lleshchi@redhat.com>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> Documentation/locking/locktypes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index 4fd7b70fcde1..bfa75ea1b66a 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
> Non-PREEMPT_RT kernels disable preemption to get this effect.
>
> PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
> - preemption disabled. The lock disables softirq handlers and also
> + preemption enabled. The lock disables softirq handlers and also
> prevents reentrancy due to task preemption.
>
> PREEMPT_RT kernels preserve all other spinlock_t semantics:
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description
2022-02-24 21:23 [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description Andrew Halaney
2022-02-25 2:22 ` Boqun Feng
@ 2022-03-04 17:13 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2022-03-04 17:13 UTC (permalink / raw)
To: Andrew Halaney
Cc: peterz, mingo, will, longman, boqun.feng, linux-doc, linux-kernel,
Andrew Halaney, Leah Leshchinsky
Andrew Halaney <ahalaney@redhat.com> writes:
> With PREEMPT_RT the _bh() version of a spinlock leaves preemption
> enabled, align the doc to say that instead of the opposite.
>
> Reported-by: Leah Leshchinsky <lleshchi@redhat.com>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> Documentation/locking/locktypes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index 4fd7b70fcde1..bfa75ea1b66a 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
> Non-PREEMPT_RT kernels disable preemption to get this effect.
>
> PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
> - preemption disabled. The lock disables softirq handlers and also
> + preemption enabled. The lock disables softirq handlers and also
> prevents reentrancy due to task preemption.
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-04 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 21:23 [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh() description Andrew Halaney
2022-02-25 2:22 ` Boqun Feng
2022-03-04 17:13 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox