From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2FFC433FE for ; Thu, 21 Oct 2021 15:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1F1460F9F for ; Thu, 21 Oct 2021 15:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbhJUPIy (ORCPT ); Thu, 21 Oct 2021 11:08:54 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:55140 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231596AbhJUPIu (ORCPT ); Thu, 21 Oct 2021 11:08:50 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]:47110) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdZeI-00HRzW-LT; Thu, 21 Oct 2021 09:06:30 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:50622 helo=email.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdZeH-00CWxY-Hi; Thu, 21 Oct 2021 09:06:30 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Greg KH Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Al Viro , Kees Cook References: <87y26nmwkb.fsf@disp2133> <20211020174406.17889-18-ebiederm@xmission.com> Date: Thu, 21 Oct 2021 10:06:22 -0500 In-Reply-To: (Greg KH's message of "Thu, 21 Oct 2021 09:06:47 +0200") Message-ID: <875ytqifip.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mdZeH-00CWxY-Hi;;;mid=<875ytqifip.fsf@disp2133>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/afZzUN9FSzTK9R8sFXt+HdCBvLvrywHY= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 18/20] exit/rtl8723bs: Replace the macro thread_exit with a simple return 0 X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Wed, Oct 20, 2021 at 12:44:04PM -0500, Eric W. Biederman wrote: >> Every place thread_exit is called is at the end of a function started >> with kthread_run. The code in kthread_run has arranged things so a >> kernel thread can just return and do_exit will be called. >> >> So just have the threads return instead of calling complete_and_exit. >> >> Signed-off-by: "Eric W. Biederman" >> --- >> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- >> drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- >> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- >> drivers/staging/rtl8723bs/include/osdep_service_linux.h | 2 -- >> 4 files changed, 3 insertions(+), 5 deletions(-) > > You "forgot" to cc: the linux-staging and the staging driver maintainer > on these drivers/staging/ changes... Yes I did. Sorry about that. > Anyway, they look fine to me, but you will get some conflicts with some > of these changes based on cleanups already in my staging-next tree (in > linux-next if you want to see them). But feel free to take these all in > your tree if that makes it easier: I just did a test merge and there was one file that was completely removed and one file with had changes a line or two above where my code changed. So nothing too difficult to result. I don't really mind either way. But keeping them all in one tree makes them easier to keep track of, and allows me to do things like see if I can remove EXPORT_SYMBOL(do_exit) as Christoph suggested. Eric > Acked-by: Greg Kroah-Hartman