public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Petr Nechaev <petr.nechaev@cogentembedded.com>
Subject: Re: [PATCH v3] usb: gadget: storage: add support for media larger than 2T
Date: Tue, 05 Oct 2021 15:07:11 +0300	[thread overview]
Message-ID: <875yubznck.fsf@kernel.org> (raw)
In-Reply-To: <YVwyDsuIT9lZWi2v@kroah.com>


Hi,

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Tue, Sep 21, 2021 at 05:59:02PM +0300, Nikita Yushchenko wrote:
>> This adds support for READ_CAPACITY(16), READ(16) and WRITE(16)
>> commands, and fixes READ_CAPACITY command to return 0xffffffff if
>> media size does not fit in 32 bits.
>> 
>> This makes f_mass_storage to export a 16T disk array correctly.
>> 
>> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
>> ---
>> v3:
>> - added this changelog
>> 
>> v2:
>> - fixed call to check_command() for READ_CAPACITY(16)
>> - fixed alphabetical order of commands in switch statement
>> - renamed variable, added comments, and fixed formatting, per advices by
>>   Alan Stern <stern@rowland.harvard.edu>
>
> Felipe and Alan, any objections to this change?

none from me, but I'd definitely wait for Alan's comments as he's the
one who understands the storage gadget inside out :-)

cheers

-- 
balbi

  reply	other threads:[~2021-10-05 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  5:27 [PATCH] usb: gadget: storage: add support for media larger than 2T Nikita Yushchenko
2021-09-14 15:13 ` Alan Stern
2021-09-14 20:09   ` [PATCH v2] " Nikita Yushchenko
2021-09-14 20:32     ` Alan Stern
2021-09-21 14:29     ` Greg Kroah-Hartman
2021-09-21 14:59       ` [PATCH v3] " Nikita Yushchenko
2021-10-05 11:07         ` Greg Kroah-Hartman
2021-10-05 12:07           ` Felipe Balbi [this message]
2021-10-05 14:19           ` Alan Stern
2021-10-10 13:08             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yubznck.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=petr.nechaev@cogentembedded.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox