public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore
Date: Fri, 04 May 2018 12:17:20 -0500	[thread overview]
Message-ID: <876043e3xb.fsf@xmission.com> (raw)
In-Reply-To: <20180504170459.624e7vkro5fn2bgw@linutronix.de> (Sebastian Andrzej Siewior's message of "Fri, 4 May 2018 19:04:59 +0200")

Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:

> On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote:
>> Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:
>> > From: Anna-Maria Gleixner <anna-maria@linutronix.de>
> …
>> > This long-term fix has been made in commit 4abf91047cf ("rtmutex: Make >
>> > wait_lock irq safe") for different reason.
>> 
>> Which tree has this change been made in?  I am not finding the commit
>> you mention above in Linus's tree.
>
> I'm sorry, it should have been commit b4abf91047cf ("rtmutex: Make
> wait_lock irq safe").

Can you fix that in your patch description and can you also up the
description of rcu_read_unlock?

If we don't need to jump through hoops it looks very reasonable to
remove this unnecessary logic.  But we should fix the description
in rcu_read_unlock that still says we need these hoops.

Eric

  reply	other threads:[~2018-05-04 17:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 14:40 [PATCH] kernel/signal: Remove no longer required irqsave/restore Sebastian Andrzej Siewior
2018-05-04 16:59 ` Eric W. Biederman
2018-05-04 17:04   ` Sebastian Andrzej Siewior
2018-05-04 17:17     ` Eric W. Biederman [this message]
2018-05-04 17:52       ` Paul E. McKenney
2018-05-04 19:03         ` Eric W. Biederman
2018-05-04 19:45           ` Paul E. McKenney
2018-05-04 20:08             ` Eric W. Biederman
2018-05-04 20:37               ` Paul E. McKenney
2018-05-05  4:38                 ` Eric W. Biederman
2018-05-05  5:25                   ` Paul E. McKenney
2018-05-05  5:56                     ` Thomas Gleixner
2018-05-08 13:42                       ` Anna-Maria Gleixner
2018-05-08 14:53                         ` Paul E. McKenney
2018-05-08 15:49                           ` Anna-Maria Gleixner
2018-05-08 16:53                             ` Paul E. McKenney
2018-06-07 20:21 ` [tip:core/urgent] signal: " tip-bot for Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876043e3xb.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=anna-maria@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox