From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751688AbdLKFaK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 00:30:10 -0500
Received: from mga06.intel.com ([134.134.136.31]:27230 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750709AbdLKFaI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 00:30:08 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; 
   d="scan'208";a="1772977"
From: "Huang\, Ying" <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, Hugh Dickins <hughd@google.com>,
        "Johannes Weiner" <hannes@cmpxchg.org>,
        Tim Chen <tim.c.chen@linux.intel.com>, "Shaohua Li" <shli@fb.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        =?utf-8?B?Su+/vXLvv71tZQ==?= Glisse <jglisse@redhat.com>,
        Michal Hocko <mhocko@suse.com>, Andrea Arcangeli <aarcange@redhat.com>,
        David Rientjes <rientjes@google.com>, Rik van Riel <riel@redhat.com>,
        Jan Kara <jack@suse.cz>, Dave Jiang <dave.jiang@intel.com>,
        Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH -mm] mm, swap: Fix race between swapoff and some swap operations
References: <20171207011426.1633-1-ying.huang@intel.com>
        <20171207162937.6a179063a7c92ecac77e44af@linux-foundation.org>
        <20171208014346.GA8915@bbox> <87po7pg4jt.fsf@yhuang-dev.intel.com>
        <20171208082644.GA14361@bbox> <87k1xxbohp.fsf@yhuang-dev.intel.com>
        <20171208140909.4e31ba4f1235b638ae68fd5c@linux-foundation.org>
Date: Mon, 11 Dec 2017 13:30:03 +0800
In-Reply-To: <20171208140909.4e31ba4f1235b638ae68fd5c@linux-foundation.org>
        (Andrew Morton's message of "Fri, 8 Dec 2017 14:09:09 -0800")
Message-ID: <87609dvnl0.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andrew Morton <akpm@linux-foundation.org> writes:

> On Fri, 08 Dec 2017 16:41:38 +0800 "Huang\, Ying" <ying.huang@intel.com> wrote:
>
>> > Why do we need srcu here? Is it enough with rcu like below?
>> >
>> > It might have a bug/room to be optimized about performance/naming.
>> > I just wanted to show my intention.
>> 
>> Yes.  rcu should work too.  But if we use rcu, it may need to be called
>> several times to make sure the swap device under us doesn't go away, for
>> example, when checking si->max in __swp_swapcount() and
>> add_swap_count_continuation().  And I found we need rcu to protect swap
>> cache radix tree array too.  So I think it may be better to use one
>> calling to srcu_read_lock/unlock() instead of multiple callings to
>> rcu_read_lock/unlock().
>
> Or use stop_machine() ;)  It's very crude but it sure is simple.  Does
> anyone have a swapoff-intensive workload?

Sorry, I don't know how to solve the problem with stop_machine().

The problem we try to resolved is that, we have a swap entry, but that
swap entry can become invalid because of swappoff between we check it
and we use it.  So we need to prevent swapoff to be run between checking
and using.

I don't know how to use stop_machine() in swapoff to wait for all users
of swap entry to finish.  Anyone can help me on this?

Best Regards,
Huang, Ying