From: Eric Anholt <eric@anholt.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, Stefan Wahren <stefan.wahren@i2se.com>,
linux-rpi-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: raspberrypi: print time using time64_t
Date: Mon, 27 Nov 2017 08:20:31 -0800 [thread overview]
Message-ID: <87609vlmls.fsf@anholt.net> (raw)
In-Reply-To: <20171127115724.3083929-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Arnd Bergmann <arnd@arndb.de> writes:
> The firmware timestamp is an unsigned 32-bit value, but we copy it into
> a signed 32-bit variable, so we can theoretically get an overflow in
> the calculation when the timestamp is between 2038 and 2106.
>
> This changes the temporary variable to time64_t and changes the deprecated
> time_to_tm() over to time64_to_tm() accordingly.
>
> There is still an overflow in y2106, but that is a limitation of the
> firmware interface, not a kernel problem.
Reviewed-by: Eric Anholt <eric@anholt.net>
I'll pull this in our branches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-11-27 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:57 [PATCH] firmware: raspberrypi: print time using time64_t Arnd Bergmann
2017-11-27 16:20 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87609vlmls.fsf@anholt.net \
--to=eric@anholt.net \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox