From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbdK0QUi (ORCPT ); Mon, 27 Nov 2017 11:20:38 -0500 Received: from anholt.net ([50.246.234.109]:34090 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbdK0QUh (ORCPT ); Mon, 27 Nov 2017 11:20:37 -0500 From: Eric Anholt To: Arnd Bergmann Cc: y2038@lists.linaro.org, Stefan Wahren , linux-rpi-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: raspberrypi: print time using time64_t In-Reply-To: <20171127115724.3083929-1-arnd@arndb.de> References: <20171127115724.3083929-1-arnd@arndb.de> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 27 Nov 2017 08:20:31 -0800 Message-ID: <87609vlmls.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Arnd Bergmann writes: > The firmware timestamp is an unsigned 32-bit value, but we copy it into > a signed 32-bit variable, so we can theoretically get an overflow in > the calculation when the timestamp is between 2038 and 2106. > > This changes the temporary variable to time64_t and changes the deprecated > time_to_tm() over to time64_to_tm() accordingly. > > There is still an overflow in y2106, but that is a limitation of the > firmware interface, not a kernel problem. Reviewed-by: Eric Anholt I'll pull this in our branches. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlocO08ACgkQtdYpNtH8 nug6XBAAmvy0pad+B/ZzQii7tWMnDyd1m3nIPnev3T6fHnSua6Xv4YZizquKXHAo KrQa52zJwTt8JR54IUWa4yVD8SubfKIp30/Tj7YXLTPdMmwRdn4HqiKWh7vofumb ZUvgZZbv3nQYPux0+uAEyihi/jnDOceLFO1kxC47B6F6m/6r+TyydhGBAUuFu+1G iQcbNf04GhA0+t56FH+RIEDSTyEYgMgTAByUBNe8NYYzgBZZSODPaNwlftymYKE8 yDuPL1gDjp033qfpI2Pdz6YDupY0keh4xMTuxX6vd2XID1LF4yNQIRnyfkiWTRm7 s6FQVfp96IyjObzMfghC4Nv+BGgM2DS3fEZISm4ZwtYe/IzFLAiKc7ut6jXGYxPu DyjllAWheRqR34tBIB/e0P6HcL7hi28MgCRoAAiH34p+BckdhV5r1ayjFNr3L0ZJ Ks6c56EVdOvRASk2I4R36GhIfVfecTi/fev1C6dsbObgxdMoA87UdZb82woYuYzS zn01OLvAohSq+DIM+7bwK6cPF/eo0uKE3+fob+HRamTovOr55BeqXR5G5nbdkgDc 2+ACxwldaXcXWeujjtdpn4ZA2KziCj6MGYaqjGUMwNQNbw/ibsXDEvyc5mT254KU DOaxJq4RgINmHE45NtblIRg8MAlHU2nck9t6QyeenhXRDgZUgGU= =aU2c -----END PGP SIGNATURE----- --=-=-=--