From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()
Date: Fri, 05 May 2017 08:51:47 +0300 [thread overview]
Message-ID: <8760hfyhos.fsf@intel.com> (raw)
In-Reply-To: <20170504200928.GL24019@nuc-i3427.alporthouse.com>
On Thu, 04 May 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Thu, 4 May 2017 13:20:47 +0200
>>
>> Some strings which did not contain data format specifications should be put
>> into a sequence. Thus use the corresponding function "seq_puts".
>
> debugfs / seq_file is not performance critical. Familiar idiomatic code is
> much preferred over continually switching between seq_printf and seq_puts.
>
> And don't even start on converting seq_printf / seq_puts to seq_putc...
Agreed. I don't want any of the seq_* changes in this series.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-05-05 5:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net>
2017-05-04 16:51 ` [PATCH 1/9] drm/i915: Replace ten seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-04 16:52 ` [PATCH 2/9] drm/i915: Combine five seq_printf() calls in i915_display_info() SF Markus Elfring
2017-05-04 16:54 ` [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() SF Markus Elfring
2017-05-04 20:09 ` Chris Wilson
2017-05-05 5:51 ` Jani Nikula [this message]
2017-05-04 16:55 ` [PATCH 4/9] drm/i915: Delete unnecessary braces in three functions SF Markus Elfring
2017-05-05 5:54 ` Jani Nikula
2017-05-04 16:56 ` [PATCH 5/9] drm/i915: Adjust seven checks for null pointers SF Markus Elfring
2017-05-05 5:46 ` Jani Nikula
2017-05-04 16:58 ` [PATCH 6/9] drm/i915: Add spaces for better code readability SF Markus Elfring
2017-05-05 5:49 ` Jani Nikula
2017-05-04 16:59 ` [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() SF Markus Elfring
2017-05-04 20:12 ` Chris Wilson
2017-05-04 20:48 ` SF Markus Elfring
2017-05-04 20:58 ` Chris Wilson
2017-05-05 4:49 ` Dan Carpenter
2017-05-04 17:00 ` [PATCH 8/9] drm/i915: Replace a seq_puts() call by seq_putc() in two functions SF Markus Elfring
2017-05-04 17:01 ` [PATCH 9/9] drm/i915: Combine substrings for two messages in i915_ggtt_probe_hw() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760hfyhos.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox