From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933476AbdCJJQY (ORCPT ); Fri, 10 Mar 2017 04:16:24 -0500 Received: from mga05.intel.com ([192.55.52.43]:14955 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222AbdCJJQV (ORCPT ); Fri, 10 Mar 2017 04:16:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,139,1486454400"; d="asc'?scan'208";a="234507659" From: Felipe Balbi To: Romain Izard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: Romain Izard , "# 4 . 9+" Subject: Re: [PATCH v2] usb: gadget: legacy gadgets are optional In-Reply-To: <20170309141046.6724-1-romain.izard.pro@gmail.com> References: <20170309141046.6724-1-romain.izard.pro@gmail.com> Date: Fri, 10 Mar 2017 11:15:20 +0200 Message-ID: <8760jhze53.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Romain Izard writes: > With commit "usb: gadget: don't couple configfs to legacy gadgets" > it is possible to build a modular kernel with both built-in configfs > support and modular legacy gadget drivers. > > But when building a kernel without modules, it is also necessary to be > able to build with configfs but without any legacy gadget driver. > > Mark the choice for legacy gadget drivers as optional. > > Fixes: bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadget= s") > Cc: # 4.9+ this is *NOT* a fix since this requirement didn't exist before. > Signed-off-by: Romain Izard > --- > changes in v2: > - Reword description > > drivers/usb/gadget/Kconfig | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 8ad203296079..e157e9aa4f3d 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -212,7 +212,7 @@ config USB_F_TCM > # this first set of drivers all depend on bulk-capable hardware. >=20=20 > config USB_CONFIGFS > - tristate "USB functions configurable through configfs" > + tristate "USB Gadget functions configurable through configfs" unrelated change > select USB_LIBCOMPOSITE > help > A Linux USB "gadget" can be set up through configfs. > @@ -458,8 +458,9 @@ config USB_CONFIGFS_F_TCM > UAS utilizes the USB 3.0 feature called streams support. >=20=20 > choice > - tristate "USB Gadget Drivers" > + tristate "USB Gadget precomposed configurations" unrelated change > default USB_ETH > + optional > help > A Linux "Gadget Driver" talks to the USB Peripheral Controller > driver through the abstract "gadget" API. Some other operating > @@ -476,6 +477,12 @@ choice > not be able work with that controller, or might need to implement > a less common variant of a device class protocol. >=20=20 > + The available choices each represent a single precomposed USB > + gadget configuration. In the device model, each option contains > + both the device instanciation as a child for a USB gadget > + controller, and the relevant drivers for each function declared > + by the device. unrelated change =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljCbqgACgkQzL64meEa mQayFhAAjJsiPEUVohxTSxnICkcrDwmQ9DyMYZVg0sWND3nz1JVq3kl6hTlPdz3c 0aVOLro2lc8UUlXthaNElNHlYCOi15RF28UNukUsLJf+vldzYKKY2v1fgu6aPhDo ecbt80eCBP2OMBMcwadRjF1Gy3oQS7fygncqsDk0l5RNl3+CRwUeIMsuY3NVouSC qeaV0/6uxKLqcndsJEaCURCYsG0XZeVM0yXtpiruN7mRFe1nHEPEXwSXfM4Adnqd xEQyDmDBD2vpsGBJGGd2iWStsuvMVTf/peUfWeLFYSodUPYzb9jKBgjAp37WBDIm 6+8R5GGZshEni8F7PV+lQCNaUVBm+gqXQ2hr0dzdYXgVU0axff9fs0/JZHx20v+x nkKGRlc5K31u6guYYRPqQssVCl4F8/1kre8N/nZ1JVLPH7GghWu0IT4AsoJTaW9D ft8bd14Qx8R5ckE+Ju8Nca6MVOEc33oy8IsP9K96ev9Qagj9xoJKeDK6SA7AiCOk iqI/VYrWStRRzDV4Ke4kwSwooa2iION6EqRPNIwjUOZNIHaw2JbW3gH72KIfQ0sg WzHnYN6ZydIIbHguoTL+Kmzkf5TXd6cpVqkgWF/+dJEPs6IOoLXiykboXlb1nOPu h5HpCPrvx9w4YcpVu4fEuZvh/FJ8lJfKRnmtkqLxIgeu3u/mOEY= =mRni -----END PGP SIGNATURE----- --=-=-=--