From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbdBOH66 (ORCPT ); Wed, 15 Feb 2017 02:58:58 -0500 Received: from mga03.intel.com ([134.134.136.65]:57840 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbdBOH65 (ORCPT ); Wed, 15 Feb 2017 02:58:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,165,1484035200"; d="asc'?scan'208";a="65980754" From: Felipe Balbi To: Lu Baolu , Mathias Nyman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events In-Reply-To: <1487126112-6069-2-git-send-email-baolu.lu@linux.intel.com> References: <1487126112-6069-1-git-send-email-baolu.lu@linux.intel.com> <1487126112-6069-2-git-send-email-baolu.lu@linux.intel.com> Date: Wed, 15 Feb 2017 09:58:21 +0200 Message-ID: <8760kbq40y.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Lu Baolu writes: > diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h > index 1ac2cdf..c31eeaf 100644 > --- a/drivers/usb/host/xhci-trace.h > +++ b/drivers/usb/host/xhci-trace.h > @@ -285,6 +285,96 @@ DEFINE_EVENT(xhci_log_urb, xhci_urb_dequeue, > TP_ARGS(urb) > ); >=20=20 > +DECLARE_EVENT_CLASS(xhci_log_cmd, > + TP_PROTO(struct xhci_command *cmd), > + TP_ARGS(cmd), > + TP_STRUCT__entry( > + __field(struct xhci_command *, cmd) > + __field(struct xhci_container_ctx *, in_ctx) > + __field(union xhci_trb *, cmd_trb) > + __field(int, slot_id) > + __field(int, status) > + __field(int, type) > + ), > + TP_fast_assign( > + __entry->cmd =3D cmd; > + __entry->in_ctx =3D cmd->in_ctx; > + __entry->cmd_trb =3D cmd->command_trb; > + __entry->slot_id =3D cmd->slot_id; > + __entry->status =3D cmd->status; > + __entry->type =3D TRB_FIELD_TO_TYPE(le32_to_cpu(cmd->command_trb->gene= ric.field[3])) > + ), > + TP_printk("cmd @%p: %s: in_ctx=3D@%p, slot_id=3D%d, cmd_trb=3D@%p, stat= us=3D%d", > + __entry->cmd, xhci_trb_type_string(__entry->type), > + __entry->in_ctx, __entry->slot_id, __entry->cmd_trb, > + __entry->status > + ) > +); we already have a generic TRB tracer that decodes every single TRB. What is this bringing that the previous doesn't provide? BTW, I also have ready Slot and EP context tracers, I didn't send before because I already had quite a large series pending for Mathias :-p =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlikCh0ACgkQzL64meEa mQYxXQ/+NAFOoDbgORa76qmUceeJ4DDLFT3ZxYctgRqumrMNr0/10OxxA1R0sCNO A0E+TtiqHXEJtTf/YCTMlKHkaNGZ1kR8VOnLVDZAUcSB1vOEs/ns1Oa5y1HOLGUM ZQkymPsxp18M5c9cXD5+8zHTbc9hDKrWMWfpvIrhuu2FtVIMSmqeAtGspH+8ZEUC p5KBPKnzU84R4/eUYkY7hkBYM78fJjcbgo/cMqfDVjOqbjGOzXKl0HAaqY/5oOSZ W5i835xObsoMYNwg1XqnzX+0bFfoqCZS5vlScWSSpeM9icAnPP4hEaw6yyIZuLrj qVt3dEcIFMryyqOzsSqNvqV+MzY5HHPLaAbI7ifTpniXF/zTuk20Xawb40POdIGa dyKu/bpeI9c0bJanfJF6Mr2yZQXFr3BAzk3+5uFE0qt5ewg+d4aDunpmKWIVk8zu Zt3YY+JT1qtIl3UqXAeR5SDFKIiF8b7gAzoHQEPFgyAx124a5Eh7MVcEVWSB05i0 VZosExa3SofPOrJl1llFjJ8vMHzTMR2e6c4W1ujxcSxwZG3iDHAHU4KS9cS54gwX SNbdxFM/GdMad/uN9FQJO7XCpMiSPHZZyq8juI2nbkGJVVASvhh/pLi8d/8M5YNs 1nc5l3y9P+RY5jGUagY5z8+5RV38fMoZqxSbalglkou74U8R3EA= =AUSD -----END PGP SIGNATURE----- --=-=-=--