From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753241AbcIGIe4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 04:34:56 -0400
Received: from mga05.intel.com ([192.55.52.43]:48466 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750938AbcIGIev (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 04:34:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; 
   d="scan'208";a="1052480415"
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Yakir Yang <ykk@rock-chips.com>, Huang Rui <ray.huang@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>, Monk Liu <Monk.Liu@amd.com>,
        Chunming Zhou <David1.Zhou@amd.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Eric Huang <JinHuiEric.Huang@amd.com>, Flora Cui <Flora.Cui@amd.com>,
        Inki Dae <inki.dae@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Dave Airlie <airlied@redhat.com>, intel-gfx@lists.freedesktop.org,
        Frediano Ziglio <fziglio@redhat.com>, Samuel Li <samuel.li@amd.com>,
        Christian =?utf-8?Q?K=C3=B6nig?= <christian.koenig@amd.com>,
        Tomasz Figa <tomasz.figa@chromium.com>,
        Sumit Semwal <sumit.semwal@linaro.org>, linux-kernel@vger.kernel.org,
        Tom St Denis <tom.stdenis@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] drm: squash lines for simple wrapper functions
In-Reply-To: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu)
Date: Wed, 07 Sep 2016 11:34:44 +0300
Message-ID: <8760q8xg4b.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 07 Sep 2016, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Remove unneeded variables and assignments.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

...

> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 95ddd56..59d029d 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1361,13 +1361,7 @@ void i915_driver_unload(struct drm_device *dev)
>  
>  static int i915_driver_open(struct drm_device *dev, struct drm_file *file)
>  {
> -	int ret;
> -
> -	ret = i915_gem_open(dev, file);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return i915_gem_open(dev, file);
>  }

Seems to me the whole function could be replaced by a direct use of
i915_gem_open().

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center