From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>, f@lunn.ch
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype
Date: Sat, 07 May 2016 16:51:29 -0400 [thread overview]
Message-ID: <8760upfv72.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160506223344.GE2073@lunn.ch>
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> On Fri, May 06, 2016 at 05:57:17PM -0400, Vivien Didelot wrote:
>> The 6131 switch models have a Core Tag Type register. Add a
>> MV88E6XXX_FLAG_CORE_TAG_TYPE flag and set the VLAN Ethertype to 0x8100
>> in the shared setup code if it is present.
>
> Do you have any idea what the core tag is?
Core Tag Type is the global register 0x19 present only on 6185 and
similar. It is used when egressing double tagged frames. This value is
also checked when ingressing frames on ports in UseCoreTag mode.
Note that we might remove this flag and setup condition, because 0x8100
is the reset value anyway.
Vivien
next prev parent reply other threads:[~2016-05-07 20:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 21:57 [PATCH net-next 00/21] net: dsa: mv88e6xxx: turn into monolithic driver Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 01/21] net: dsa: mv88e6xxx: add flags to info Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 02/21] net: dsa: mv88e6xxx: factorize PHY access with PPU Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 03/21] net: dsa: mv88e6xxx: factorize PHY indirect access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 04/21] net: dsa: mv88e6xxx: factorize EEPROM access Vivien Didelot
2016-05-06 22:20 ` Andrew Lunn
2016-05-06 21:57 ` [PATCH net-next 05/21] net: dsa: mv88e6xxx: factorize temperature access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 06/21] net: dsa: mv88e6xxx: factorize MAC address setting Vivien Didelot
2016-05-06 22:23 ` Andrew Lunn
2016-05-07 20:37 ` Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 07/21] net: dsa: mv88e6xxx: factorize EEE access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 08/21] net: dsa: mv88e6xxx: factorize registers access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 09/21] net: dsa: mv88e6xxx: factorize bridge support Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 10/21] net: dsa: mv88e6xxx: factorize VTU access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 11/21] net: dsa: mv88e6xxx: factorize ATU access Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 12/21] net: dsa: mv88e6xxx: factorize switch reset Vivien Didelot
2016-05-06 22:27 ` Andrew Lunn
2016-05-06 21:57 ` [PATCH net-next 13/21] net: dsa: mv88e6xxx: factorize global setup Vivien Didelot
2016-05-06 22:29 ` Andrew Lunn
2016-05-06 21:57 ` [PATCH net-next 14/21] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype Vivien Didelot
2016-05-06 22:33 ` Andrew Lunn
2016-05-07 20:51 ` Vivien Didelot [this message]
2016-05-06 21:57 ` [PATCH net-next 16/21] net: dsa: mv88e6xxx: factorize GLOBAL_MONITOR_CONTROL setup Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 17/21] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL_2 setup Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 18/21] net: dsa: mv88e6xxx: factorize frames priorities Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 19/21] net: dsa: mv88e6xxx: factorize switch setup Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 20/21] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot
2016-05-06 21:57 ` [PATCH net-next 21/21] net: dsa: mv88e6xxx: factorize the switch driver Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760upfv72.fsf@ketchup.mtl.sfl \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=f@lunn.ch \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox