From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701AbcBHQbd (ORCPT ); Mon, 8 Feb 2016 11:31:33 -0500 Received: from down.free-electrons.com ([37.187.137.238]:42241 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753286AbcBHQbb convert rfc822-to-8bit (ORCPT ); Mon, 8 Feb 2016 11:31:31 -0500 From: Gregory CLEMENT To: Masahiro Yamada Cc: linux-arm-kernel@lists.infradead.org, Andrew Lunn , Sebastian Hesselbarth , Jason Cooper , linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH] ARM: mvebu: add missing of_node_put() References: <1454912232-13169-1-git-send-email-yamada.masahiro@socionext.com> Date: Mon, 08 Feb 2016 17:31:20 +0100 In-Reply-To: <1454912232-13169-1-git-send-email-yamada.masahiro@socionext.com> (Masahiro Yamada's message of "Mon, 8 Feb 2016 15:17:12 +0900") Message-ID: <8760xz17vr.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On lun., févr. 08 2016, Masahiro Yamada wrote: > This node pointer is returned by of_find_compatible_node() in this > function. It should be put before exitting this function. > Applied on mvebu/cleanup Thanks, Gregory > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-mvebu/platsmp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c > index f9597b7..46c742d 100644 > --- a/arch/arm/mach-mvebu/platsmp.c > +++ b/arch/arm/mach-mvebu/platsmp.c > @@ -140,6 +140,7 @@ static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus) > panic("Cannot find 'marvell,bootrom' compatible node"); > > err = of_address_to_resource(node, 0, &res); > + of_node_put(node); > if (err < 0) > panic("Cannot get 'bootrom' node address"); > > -- > 1.9.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com