From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbbI1Xb2 (ORCPT ); Mon, 28 Sep 2015 19:31:28 -0400 Received: from ozlabs.org ([103.22.144.67]:52543 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbbI1Xb1 (ORCPT ); Mon, 28 Sep 2015 19:31:27 -0400 From: Rusty Russell To: Rasmus Villemoes Cc: Thomas Gleixner , Oleg Nesterov , "Paul E. McKenney" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] kernel/cpu.c: eliminate some indirection In-Reply-To: <87si5zf4il.fsf@rasmusvillemoes.dk> References: <1443205347-13634-1-git-send-email-linux@rasmusvillemoes.dk> <87twqgpe4y.fsf@rustcorp.com.au> <87si5zf4il.fsf@rasmusvillemoes.dk> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 29 Sep 2015 07:14:49 +0930 Message-ID: <87612up6b2.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rasmus Villemoes writes: > On Sun, Sep 27 2015, Rusty Russell wrote: > >> But to be clear, it has outlived its usefulness, but it was not useless. >> >> In particular, there used to be a debug config where 'struct cpumask' >> wasn't defined, so we could catch people declaring 'struct cpumask' on >> the stack (or passing by value). >> >> There was a plan to remove CONFIG_NR_CPUS (ie. having no compile-time >> cpu limit), but it seemed overkill and was abandoned. But avoiding >> 'struct cpumask' (not struct cpumask *) in the core wherever possible >> was a step towards it. >> >> Hope that clarifies, > > It does, thanks! Should some of that be edited into one of the > changelogs? Well, you could describe it as "now-useless", since it looks like you've got another rev coming anyway? Cheers, Rusty.