From: Rusty Russell <rusty@rustcorp.com.au>
To: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrew Honig <ahonig@google.com>, Michal Marek <mmarek@suse.cz>,
"x86\@kernel.org" <x86@kernel.org>, Tejun Heo <tj@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, keescook@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kallsyms: handle special absolute symbols
Date: Fri, 07 Mar 2014 13:55:00 +1030 [thread overview]
Message-ID: <8761nqzo4z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1394152324-26304-3-git-send-email-keescook@chromium.org>
Kees Cook <keescook@chromium.org> writes:
> This forces the entire per_cpu range to be reported as absolute without
> losing their linker symbol types. Without this, the variables are
> incorrectly shown as relocated under kASLR.
I like these patches, thanks!
This one's a bit broken, since the zero-based __per_cpu_start/end thing
is an x86-64-ism. You really do want them relocated on other
platforms, so I think you'll need do make this conditional via
a --per-cpu-absolute flag to kallsyms (which x86-64 would set).
Dumb Q: why don't we actually present these symbols as absolute in
/proc/kallsyms? Seems like it would be clearer...
Thanks,
Rusty.
next prev parent reply other threads:[~2014-03-07 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 0:32 [PATCH 0/2] kallsyms: handle special absolute symbols Kees Cook
2014-03-07 0:32 ` [PATCH 1/2] kallsyms: generalize address range checking Kees Cook
2014-03-07 0:32 ` [PATCH 2/2] kallsyms: handle special absolute symbols Kees Cook
2014-03-07 3:25 ` Rusty Russell [this message]
2014-03-07 5:42 ` Kees Cook
2014-03-07 12:25 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761nqzo4z.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ahonig@google.com \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=keescook@chromium.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox