Re: [PATCH] perf: fix bug in isupper() and islower()

[Namhyung Kim <namhyung@kernel.org>]

Hi Sukadev,

On Fri, 29 Mar 2013 12:29:50 -0700, Sukadev Bhattiprolu wrote:
> From fd349681226bf7b27c9d0f72b0f3941b5aa94f78 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Fri, 29 Mar 2013 12:14:43 -0700
> Subject: [PATCH] perf: fix bug in isupper() and islower()
>
> One of the reasons 'perf test' is failing on Power appears to be due to
> a bug in isupper().
>
> isupper(c) and islower(c) should be checking 'c' against the mask 0x20.
> Instead they are checking sane_ctype[c] which causes isupper() to be true
> for lower case letters.

Indeed!

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
>  tools/perf/util/util.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 09b4c26..2795ef6 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -219,8 +219,8 @@ extern unsigned char sane_ctype[256];
>  #define isalpha(x) sane_istest(x,GIT_ALPHA)
>  #define isalnum(x) sane_istest(x,GIT_ALPHA | GIT_DIGIT)
>  #define isprint(x) sane_istest(x,GIT_PRINT)
> -#define islower(x) (sane_istest(x,GIT_ALPHA) && sane_istest(x,0x20))
> -#define isupper(x) (sane_istest(x,GIT_ALPHA) && !sane_istest(x,0x20))
> +#define islower(x) (sane_istest(x,GIT_ALPHA) && (x & 0x20))
> +#define isupper(x) (sane_istest(x,GIT_ALPHA) && !(x & 0x20))
>  #define tolower(x) sane_case((unsigned char)(x), 0x20)
>  #define toupper(x) sane_case((unsigned char)(x), 0)