public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: linux-mmc@vger.kernel.org, merez@codeaurora.org,
	linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5
Date: Thu, 19 Jul 2012 02:46:11 -0400	[thread overview]
Message-ID: <87629k9rkc.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1340872367-16206-3-git-send-email-ygardi@codeaurora.org> (Yaniv Gardi's message of "Thu, 28 Jun 2012 11:32:46 +0300")

Hi Yaniv,

On Thu, Jun 28 2012, Yaniv Gardi wrote:
> This feature delete the unmap memory region of the eMMC card,
> by writing to a specific register in the EXT_CSD
> unmap region is the memory region that were previously deleted
> (by erase, trim or discard operation)
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

Did you reply to Chuanxiao's review comments yet?  He said:

"So to implement your scenario, how about only add
mmc_blk_issue_sanitize_rq() for REQ_SANITIZE but not touch
mmc_blk_issue_secdiscard_rq()? With your changes in
mmc_blk_issue_secdiscard_rq(), eMMC4.5 device will be failed to operate
secure trim/erase for REQ_SECURE request."

at: http://thread.gmane.org/gmane.linux.kernel.mmc/14822/focus=14880

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2012-07-19  6:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1340872367-16206-1-git-send-email-ygardi@codeaurora.org>
2012-06-28  8:32 ` [PATCH RESEND v7 1/2] block: ioctl support for sanitize in eMMC 4.5 Yaniv Gardi
2012-06-28  8:41   ` merez
2012-07-17 10:48     ` Yaniv Gardi
2012-07-09  8:37   ` Girish K S
2012-07-09  9:03   ` Girish K S
2012-07-09 10:02   ` Girish K S
2012-06-28  8:32 ` [PATCH RESEND v7 2/2] mmc: card: Adding " Yaniv Gardi
2012-06-28  8:43   ` merez
2012-07-17 10:51     ` Yaniv Gardi
2012-07-19  6:46   ` Chris Ball [this message]
2012-07-19 11:25     ` merez
2012-07-24  6:40       ` Yaniv Gardi
2012-07-24  6:56         ` Chris Ball
2012-07-25  9:39           ` Yaniv Gardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87629k9rkc.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=merez@codeaurora.org \
    --cc=ygardi@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox