public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Steven J. Magnani" <steve@digidescorp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Refactor shortname parsing
Date: Mon, 02 Jul 2012 23:36:47 +0900	[thread overview]
Message-ID: <8762a6nsao.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1341237638.1695.16.camel@iscandar.digidescorp.com> (Steven J. Magnani's message of "Mon, 02 Jul 2012 09:00:38 -0500")

"Steven J. Magnani" <steve@digidescorp.com> writes:

> True, but with the change you suggest we lose the incrementing of 'i',
> which likely would cause an infinite loop for 1:1 Unicode conversions.

You meant, we just have to do

	if (!is_vfat)
        	ptname[i] = ...;
	i++;

or something? I still feel this looks better to indicate, we don't use
ptname in the case of vfat.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2012-07-02 14:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 18:12 [PATCH] fat: Refactor shortname parsing Steven J. Magnani
2012-06-29 19:08 ` OGAWA Hirofumi
2012-06-29 19:13   ` Steven J. Magnani
2012-06-29 20:03     ` OGAWA Hirofumi
2012-06-29 20:09       ` OGAWA Hirofumi
2012-07-02 13:01         ` Steven J. Magnani
2012-07-02 13:40           ` OGAWA Hirofumi
2012-07-02 14:00             ` Steven J. Magnani
2012-07-02 14:36               ` OGAWA Hirofumi [this message]
2012-07-02 14:45                 ` Steven J. Magnani
2012-07-02 15:11                   ` OGAWA Hirofumi
2012-07-02 15:51                     ` Steven J. Magnani
2012-07-02 16:59                       ` OGAWA Hirofumi
  -- strict thread matches above, loose matches on Subject: below --
2012-07-03 11:14 Steven J. Magnani
2012-07-03 11:28 ` OGAWA Hirofumi
2012-08-03 14:52 ` Jan Engelhardt
2012-08-03 15:06   ` OGAWA Hirofumi
2012-08-03 15:58     ` Jan Engelhardt
2012-08-03 16:09       ` Steven J. Magnani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762a6nsao.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@digidescorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox