public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Dmitry Antipov <dmitry.antipov@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	patches@linaro.org, Dmitry Antipov <dmitry.antipov@linaro.org>
Subject: Re: [PATCH] module: avoid call vmalloc if init size is zero
Date: Fri, 27 Jan 2012 21:51:54 +1030	[thread overview]
Message-ID: <8762fxcrvx.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1327648756-22255-1-git-send-email-dmitry.antipov@linaro.org>

On Fri, 27 Jan 2012 11:19:16 +0400, Dmitry Antipov <dmitry.antipov@linaro.org> wrote:
> For the architectures with it's own module_alloc(), if module init
> size is zero, avoiding module_alloc_update_bounds() and memset()
> no-op calls also eliminates warn_alloc_failed() zero-size warning
> in __vmalloc_node_range().
> 
> Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>

Please fix __vmalloc_node_range() instead to return ZERO_SIZE_PTR.
And of course, vfree() to use ZERO_OR_NULL_PTR().

Thanks,
Rusty.

  reply	other threads:[~2012-01-27 21:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27  7:19 [PATCH] module: avoid call vmalloc if init size is zero Dmitry Antipov
2012-01-27 11:21 ` Rusty Russell [this message]
2012-01-30  7:28   ` Dmitry Antipov
2012-01-30  7:54     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762fxcrvx.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=dmitry.antipov@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox