From: Rusty Russell <rusty@rustcorp.com.au>
To: Ben Hutchings <ben@decadent.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Nick Bowler <nbowler@elliptictech.com>, Greg KH <greg@kroah.com>,
Dave Jones <davej@redhat.com>,
Randy Dunlap <rdunlap@xenotime.net>,
LKML <linux-kernel@vger.kernel.org>,
Debian kernel maintainers <debian-kernel@lists.debian.org>
Subject: Re: [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging
Date: Thu, 08 Dec 2011 15:00:25 +1030 [thread overview]
Message-ID: <8762hrit26.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1323268258.18450.11.camel@deadeye>
On Wed, 07 Dec 2011 14:30:58 +0000, Ben Hutchings <ben@decadent.org.uk> wrote:
> We do want to allow lock debugging for GPL-compatible modules that are
> not (yet) built in-tree. This was disabled as a side-effect of commit
> 2449b8ba0745327c5fa49a8d9acffe03b2eded69 ('module,bug: Add
> TAINT_OOT_MODULE flag for modules not built in-tree'). Lock debug
> warnings now include taint flags, so kernel developers should still
> be able to deflect warnings caused by out-of-tree modules.
>
> The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules will
> still disable lock debugging.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Meh. Disabling lock debugging was always a weird thing to do, IMHO.
Taint flags should be used for warnings to developers, not these strange
side-effects.
Cheers,
Rusty.
next prev parent reply other threads:[~2011-12-08 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 14:30 [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging Ben Hutchings
2011-12-08 4:30 ` Rusty Russell [this message]
2011-12-08 4:37 ` [tip:core/locking] " tip-bot for Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762hrit26.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ben@decadent.org.uk \
--cc=davej@redhat.com \
--cc=debian-kernel@lists.debian.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nbowler@elliptictech.com \
--cc=peterz@infradead.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox