From: Andi Kleen <andi@firstfloor.org>
To: "Penttilä Mika" <mika.penttila@ixonos.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining
Date: Tue, 12 Oct 2010 16:06:08 +0200 [thread overview]
Message-ID: <8762x733qn.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1A61D8EA6755AF458F06EA669A4EC81815FDA6FE@JKLMAIL02.ixonos.local> (Penttil's message of "Tue, 12 Oct 2010 12:38:10 +0000")
Penttilä Mika <mika.penttila@ixonos.com> writes:
Please always cc people when answering list emails.
Missed this earlier.
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -564,6 +564,8 @@ static inline int free_pages_check(struct page *page)
>> (page->mapping != NULL) |
>> (atomic_read(&page->_count) != 0) |
>> (page->flags & PAGE_FLAGS_CHECK_AT_FREE))) {
>> + if (PageHWPoisonOnFree(page))
>> + hwpoison_page_on_free(page);
>
> hwpoison_page_on_free() seems to be undefined when
> CONFIG_HWPOISON_ON_FREE is not defined.
The optimizer takes care of that.
>
>> bad_page(page);
>> return 1;
>> }
>
> And of course PAGE_FLAGS_CHECK_AT_FREE should include
> pahehwpoisononfree this to be effective
It is of course (__PG_HWPOISON_ON_FREE)
Thanks for the review.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-10-12 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 12:38 [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining Penttilä Mika
2010-10-12 14:06 ` Andi Kleen [this message]
2010-10-12 14:23 ` Penttilä Mika
2010-10-12 14:30 ` Andi Kleen
2010-10-12 14:33 ` Penttilä Mika
-- strict thread matches above, loose matches on Subject: below --
2010-10-06 22:09 RFC: Implement hwpoison on free " Andi Kleen
2010-10-06 22:09 ` [PATCH] HWPOISON: Implement hwpoison-on-free " Andi Kleen
2010-10-12 12:26 ` Wu Fengguang
2010-10-12 12:37 ` Andi Kleen
2010-10-12 12:41 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762x733qn.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@ixonos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox