From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: arun@linux.vnet.ibm.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@in.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arch@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [v8 PATCH 2/8]: cpuidle: implement a list based approach to register a set of idle routines.
Date: Mon, 12 Oct 2009 20:00:05 +0200 [thread overview]
Message-ID: <8763akh4re.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1254999033.26976.272.camel@twins> (Peter Zijlstra's message of "Thu, 08 Oct 2009 12:50:33 +0200")
Peter Zijlstra <a.p.zijlstra@chello.nl> writes:
>
> So does it make sense to have a set of sets?
>
> Why not integrate them all into one set to be ruled by this governor
> thing?
cpuidle is currently optional, that is why the two level hierarchy
is there so that you can still have simple idle selection without it.
% size drivers/cpuidle/*.o
text data bss dec hex filename
5514 1416 44 6974 1b3e drivers/cpuidle/built-in.o
Adding it unconditionally would add ~7k to everyone who wants idle functions.
I think making it unconditional would require putting it on a serious
diet first.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-12 18:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 9:48 [v8 PATCH 0/8]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER Arun R Bharadwaj
2009-10-08 9:49 ` [v8 PATCH 1/8]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Arun R Bharadwaj
2009-10-12 11:36 ` Balbir Singh
2009-10-14 6:24 ` Arun R Bharadwaj
2009-10-08 9:50 ` [v8 PATCH 2/8]: cpuidle: implement a list based approach to register a set of idle routines Arun R Bharadwaj
2009-10-08 10:36 ` Peter Zijlstra
2009-10-08 10:42 ` Arun R Bharadwaj
2009-10-08 10:50 ` Peter Zijlstra
2009-10-08 11:01 ` Arun R Bharadwaj
2009-10-08 11:25 ` Peter Zijlstra
2009-10-08 12:01 ` Arun R Bharadwaj
2009-10-08 12:25 ` Peter Zijlstra
2009-10-08 13:10 ` Vaidyanathan Srinivasan
2009-10-09 9:39 ` Arun R Bharadwaj
2009-10-12 18:00 ` Andi Kleen [this message]
2009-10-14 6:17 ` Arun R Bharadwaj
2009-10-14 7:18 ` Andi Kleen
2009-10-15 6:06 ` Arun R Bharadwaj
2009-10-08 9:51 ` [v8 PATCH 3/8]: x86: refactor x86 idle power management code and remove all instances of pm_idle Arun R Bharadwaj
2009-10-08 9:52 ` [v8 PATCH 4/8]: POWER: enable cpuidle for POWER Arun R Bharadwaj
2009-10-08 9:53 ` [v8 PATCH 5/8]: pSeries/cpuidle: remove dedicate/shared idle loops, which will be moved to arch/powerpc/platforms/pseries/processor_idle.c Arun R Bharadwaj
2009-10-08 9:53 ` [v8 PATCH 6/8]: POWER: add a default_idle idle loop for POWER Arun R Bharadwaj
2009-10-08 9:54 ` [v8 PATCH 7/8]: pSeries: implement pSeries processor idle module Arun R Bharadwaj
2009-10-08 9:56 ` [v8 PATCH 8/8]: POWER: Enable default_idle when power_save=off Arun R Bharadwaj
2009-10-12 10:01 ` [v8 PATCH 0/8]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763akh4re.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=arun@linux.vnet.ibm.com \
--cc=balbir@in.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dipankar@in.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox