Re: [PATCH 2/3] c/r: Add CR_COPY() macro (v3)

Nathan Lynch
2009-03-04T19:53:42Z

On Tue, 03 Mar 2009 17:00:37 -0800
Dave Hansen <dave@linux.vnet.ibm.com> wrote:

> On Tue, 2009-03-03 at 16:57 -0800, Dan Smith wrote:
> > DH> Did you convince Nathan that this ends up being a good idea?
> >
> > Technically he hasn't seen this version, but my hopes are not high
> > that he will change his mind. If the feedback is that they're not
> > liked, I'll happily remove them.
>
> I just figure if Nathan feels that strongly that we'll encounter more
> people who feel even more so. So, I was curious if he changed his mind
> somehow.

No, not really, sorry.

I understand why it's nice for the developer to have this sort of
helper, but I don't think it's nice for someone trying to review or
debug the code.

Surely discussing these macros has already consumed more developer time
than they would ever save? :)