From: Johannes Weiner <hannes@saeurebad.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK
Date: Tue, 22 Jul 2008 17:18:16 +0200 [thread overview]
Message-ID: <8763qyj6br.fsf@saeurebad.de> (raw)
In-Reply-To: <4885F43B.7060307@goop.org> (Jeremy Fitzhardinge's message of "Tue, 22 Jul 2008 07:52:43 -0700")
Hi,
Jeremy Fitzhardinge <jeremy@goop.org> writes:
> Johannes Weiner wrote:
>> PTE_PFN_MASK is not symmetric to PAGE_MASK.
>
> No, it isn't. Is there anything about the name that suggests that it
> should be? PTE_PFN_MASK is for operating on pteval_t-typed values
> extracted from ptes; PAGE_MASK is for operating on addresses.
I meant the naming scheme, not the functionality.
The thing PAGE_MASK and PTE_MASK have in common is that they are masks
and their names indicate what is masked away when applied.
So PAGE_MASK suggests that it masks out page details. And PTE_MASK
suggests that it masks out PTE details.
PTE_PFN_MASK masks suggests that it masks out the flags, according to
the existing naming convention. But it does the opposite.
Hannes
next prev parent reply other threads:[~2008-07-22 15:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 4:31 [PATCH] x86: fix pte_flags() to only return flags, fix lguest Rusty Russell
2008-07-22 4:38 ` Stephen Rothwell
2008-07-22 4:51 ` Jeremy Fitzhardinge
2008-07-22 4:52 ` Rusty Russell
2008-07-22 4:49 ` Jeremy Fitzhardinge
2008-07-22 5:40 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Rusty Russell
2008-07-22 5:59 ` [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK Jeremy Fitzhardinge
2008-07-22 8:36 ` Ingo Molnar
2008-07-22 10:58 ` Rusty Russell
2008-07-22 11:55 ` Ingo Molnar
2008-07-22 13:03 ` Johannes Weiner
2008-07-22 14:52 ` Jeremy Fitzhardinge
2008-07-22 15:18 ` Johannes Weiner [this message]
2008-07-22 15:23 ` Johannes Weiner
2008-07-22 15:33 ` Ingo Molnar
2008-07-22 15:43 ` Johannes Weiner
2008-07-22 5:59 ` [PATCH 2/2] x86: add PTE_FLAGS_MASK Jeremy Fitzhardinge
2008-07-22 9:04 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Ingo Molnar
2008-07-23 0:59 ` Rusty Russell
2008-07-24 11:31 ` Ingo Molnar
2008-07-25 1:55 ` Rusty Russell
2008-07-28 15:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763qyj6br.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox